committed #36
committed #36
Conversation
| @@ -0,0 +1,18 @@ | |||
| { | |||
There was a problem hiding this comment.
We didn't use EAS build system as it can't support no-account offline builds.
Based on the package.json, this port also doesn't use EAS.
Hence are we able to drop it?
| @@ -1,27 +1,53 @@ | |||
| { | |||
| "name": "@safsbe/mental-health-app-monorepo", | |||
| "name": "mental-health-app", | |||
There was a problem hiding this comment.
| "name": "mental-health-app", | |
| "name": "@safsbe/mental-health-app", |
| "expo-constants": "~16.0.2", | ||
| "expo-font": "~12.0.9", | ||
| "expo-linking": "~6.3.1", | ||
| "expo-router": "~3.5.23", |
There was a problem hiding this comment.
Do we want to be locked into expo-router and file-based routing?
There was a problem hiding this comment.
Since expo-router uses react-navigation, we are able to mix-and-match as needed. So it should have minimal lock-in.
Nit: expo-router does not like files .# prefix, which are lockfiles produced by certain editors:
Error: ENOENT: no such file or directory, stat '[...]/app/(tabs)/.#sos.tsx'
at Object.statSync (node:fs:1665:25)
at [...]/node_modules/expo-router/src/testing-library/require-context-ponyfill.ts:24:14
at Array.forEach (<anonymous>)
at readDirectory ([...]/node_modules/expo-router/src/testing-library/require-context-ponyfill.ts:20:31)
at [...]/node_modules/expo-router/src/testing-library/require-context-ponyfill.ts:25:33
at Array.forEach (<anonymous>)
at readDirectory ([...]/node_modules/expo-router/src/testing-library/require-context-ponyfill.ts:20:31)
at requireContext ([...]/node_modules/expo-router/src/testing-library/require-context-ponyfill.ts:37:5)
at Object.<anonymous> ([...]/node_modules/expo-router/src/typed-routes/index.ts:11:34)
at Module._compile (node:internal/modules/cjs/loader:1469:14)
| @@ -1,28 +0,0 @@ | |||
| # Contributing | |||
| @@ -1 +0,0 @@ | |||
| * text=auto eol=lf | |||
There was a problem hiding this comment.
Keep this file. Forces CRLF->LF conversion, which prevents inconsistent newline sequences introduced on Windows environments.
| @@ -1,40 +1,25 @@ | |||
| # SBE Mental Health App | |||
There was a problem hiding this comment.
Can we keep the original README structure?
| props: { light?: string; dark?: string }, | ||
| colorName: keyof typeof Colors.light & keyof typeof Colors.dark | ||
| ) { | ||
| const theme = useColorScheme() ?? 'light'; |
There was a problem hiding this comment.
Keep it to light mode.
Dark mode has not been drafted or discussed with UI/UX team.
| @@ -1,4 +0,0 @@ | |||
| # Developing | |||
There was a problem hiding this comment.
Retain this file.
On the #TODO to fill it with actual details.
| "ios": "expo start --ios", | ||
| "web": "expo start --web", | ||
| "test": "jest --watchAll", | ||
| "lint": "expo lint" |
There was a problem hiding this comment.
Retain Android App Bundle (AAB) build command.
| "lint": "expo lint" | |
| "lint": "expo lint", | |
| "dev-test-android-build": "react-native bundle --dev false --platform android --entry-file app/index.js --bundle-output ./android/app/src/main/assets/index.android.bundle --assets-dest ./android/app/src/main/res/" |
| const colorScheme = useColorScheme(); | ||
| const [isReady, setIsReady] = useState(false); | ||
| const [loaded] = useFonts({ | ||
| SpaceMono: require('../assets/fonts/SpaceMono-Regular.ttf'), |
There was a problem hiding this comment.
Use Mulish font as dictated by UI Team.
|
Superseded by: #37 |
Changed from Clojurescript to Typescript