Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bytes dependency & update Body constructors #261

Merged
merged 2 commits into from
Nov 24, 2020
Merged

Conversation

sagebind
Copy link
Owner

Remove bytes as a direct dependency, as our small usage does not really justify its inclusion. In addition, update the constructor methods for Body to reflect this change. These changes are minor but breaking, but encourage using the From traits more so as to reduce copying when possible.

Remove bytes as a direct dependency, as our small usage does not really justify its inclusion. In addition, update the constructor methods for `Body` to reflect this change. These changes are minor but breaking, but encourage using the `From` traits more so as to reduce copying when possible.
@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #261 (8251f5d) into master (5212209) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
- Coverage   71.86%   71.84%   -0.02%     
==========================================
  Files          49       49              
  Lines        2513     2515       +2     
==========================================
+ Hits         1806     1807       +1     
- Misses        707      708       +1     
Impacted Files Coverage Δ
src/body.rs 74.62% <73.68%> (-0.76%) ⬇️
tests/redirects.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5212209...8251f5d. Read the comment docs.

@sagebind sagebind merged commit 6a399a2 into master Nov 24, 2020
@sagebind sagebind deleted the remove-bytes branch November 24, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant