Implement minpoly() for approximate values #39017
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36798 .
There are a few things that are worth discussing.
Is it a good idea to test calling
minpoly()
where there are insufficient precision or input is transcendental? Currently it returns an "arbitrary" polynomial, but it may raise an error instead in the future or if some floating point changed.Is calling the method
minpoly
actually a good idea? However notice that currentlybecause the operation casts it to
SR
and things just work out… somehow.Either we should disable this behavior (and call the method something like
minpoly_approximate
), or we should implement the method for pureRR
for consistency.📝 Checklist
⌛ Dependencies