Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement minpoly() for approximate values #39017

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

user202729
Copy link
Contributor

Fixes #36798 .

There are a few things that are worth discussing.

  • Is it a good idea to test calling minpoly() where there are insufficient precision or input is transcendental? Currently it returns an "arbitrary" polynomial, but it may raise an error instead in the future or if some floating point changed.

  • Is calling the method minpoly actually a good idea? However notice that currently

    sage: minpoly(RR(1.2)*x/x)
    x - 6/5

    because the operation casts it to SR and things just work out… somehow.

    Either we should disable this behavior (and call the method something like minpoly_approximate), or we should implement the method for pure RR for consistency.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Nov 21, 2024

Documentation preview for this PR (built with commit c5ea5e9; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@kwankyu
Copy link
Collaborator

kwankyu commented Feb 10, 2025

@mezzarobba ?

@mezzarobba
Copy link
Member

mezzarobba commented Feb 10, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow finding minimal polynomial of RIF/CIF element?
3 participants