Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump @opentelemetry/sdk-trace-node from 1.30.0 to 1.30.1 #241

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 20, 2025

Bumps @opentelemetry/sdk-trace-node from 1.30.0 to 1.30.1.

Release notes

Sourced from @​opentelemetry/sdk-trace-node's releases.

v1.30.1

1.30.1

🐛 (Bug Fix)

  • fix(sdk-metrics): do not export from PeriodicExportingMetricReader when there are no metrics to export. #5288 @​jacksonweber

🏠 (Internal)

Changelog

Sourced from @​opentelemetry/sdk-trace-node's changelog.

1.30.1

🐛 (Bug Fix)

  • fix(sdk-metrics): do not export from PeriodicExportingMetricReader when there are no metrics to export. #5288 @​jacksonweber

🏠 (Internal)

Commits
  • cbc912d chore: prepare next v1.x release (#5342)
  • 942628d [backport/v1.x] ci: make v1.x release PR workflow checkout correct branch (#5...
  • 1fa5492 [backport/v1.x] fix(exporter-metrics-otlp-http): browser OTLPMetricExporter w...
  • 18b33a0 [backport/v1.x] fix(sdk-metrics): don't export from PeriodicExportingMetricRe...
  • 3acae30 [backport/v1.x] ci: make changelog workflow check v1.x (#5338)
  • dba373c chore: updated v1.x supported versions (#5286)
  • aae4468 ci: prepare release script to run on v1.x branch (#5276)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jan 20, 2025
@dependabot dependabot bot requested a review from saidsef January 20, 2025 23:16
github-actions[bot]
github-actions bot previously approved these changes Jan 20, 2025
@dependabot dependabot bot force-pushed the dependabot-npm_and_yarn-opentelemetry-sdk-trace-node-1.30.1 branch from 783afcb to 46df73f Compare January 21, 2025 15:38
Bumps [@opentelemetry/sdk-trace-node](https://github.com/open-telemetry/opentelemetry-js) from 1.30.0 to 1.30.1.
- [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/v1.30.1/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-js@v1.30.0...v1.30.1)

---
updated-dependencies:
- dependency-name: "@opentelemetry/sdk-trace-node"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@saidsef saidsef force-pushed the dependabot-npm_and_yarn-opentelemetry-sdk-trace-node-1.30.1 branch from 46df73f to ddf9231 Compare January 25, 2025 09:38
github-actions[bot]
github-actions bot previously approved these changes Jan 25, 2025
Copy link
Owner

@saidsef saidsef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saidsef
Copy link
Owner

saidsef commented Jan 25, 2025

/code pr

Copy link
Owner

@saidsef saidsef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖

Issues and Suggestions

package-lock.json

Issue in Dependencies:

  • node_modules/@babel/core: The dependency @babel/code-frame has been updated from "^7.26.0" to "^7.26.2". It's good practice to ensure that the new version does not introduce any breaking changes. Verify compatibility.
  • node_modules/@babel/core: The dependency @babel/generator has been updated from "^7.26.0" to "^7.26.5". Verify that there are no breaking changes or unforeseen side effects.
  • node_modules/@babel/core: The dependency @babel/helper-plugin-utils has been updated from "^7.26.0" to "^7.26.5". Similar to above, ensure the update is non-breaking.
  • node_modules/@babel/core: The dependency @babel/helper-compilation-targets has been updated from "^7.25.9" to "^7.26.5". Verify this update.
  • node_modules/@babel/traverse: The dependency @babel/types has been updated from "^7.26.3" to "^7.26.7". Ensure the upgrade is stable.
  • node_modules/@babel/generator: The dependency @babel/types has been updated from "^7.26.3" to "^7.26.5". Verify compatibility.
  • node_modules/@babel/types: The package was updated from 7.26.3 to 7.26.7. This is generally safe, but cross-check the new release notes or changelog for any breaking changes.

Issue in Peer Dependencies:

  • node_modules/@opentelemetry/propagator-b3 and node_modules/@opentelemetry/propagator-jaeger: These updates include new dependencies on @opentelemetry/core version 1.30.1. The integrity of the new version and its integration with existing code should be verified to ensure no issues arise from this change.

Suggestions:

  • Re-run integration tests to ensure that the updated dependencies and their interactions do not introduce regressions or unexpected behavior.
  • Update the package-lock.json with the correct dependency stubs for @opentelemetry/sdk-trace-node/node_modules/@opentelemetry/core and @opentelemetry/sdk-trace-node/node_modules/@opentelemetry/resources if they are still in use after the update, and are not extraneous.

package.json

Issue:

  • The package version has been incremented from 3.0.3 to 3.0.4, reflecting the minor change to dependency versions. Ensure that this change properly reflects the semantic versioning policy in place.

Suggestions:

  • Document the changes introduced by upgrading dependencies in the project's CHANGELOG to maintain transparency for other contributors and maintainers.
  • Review the specific updates within the new version of the @opentelemetry/sdk-trace-node and other dependencies for any new features or security patches that could be relevant to the project.

Example of Dependency Checking

// Check package.json or docs/changelog for this entry
"Bump @opentelemetry/sdk-trace-node to 1.30.1 to leverage enhanced tracing features and security updates"

// In package.json
"dependencies": {
    "@opentelemetry/sdk-trace-node": "^1.30.1"
}

Review these updates and suggestions to ensure they align with the project's development workflow and testing practices.

> Qwen/Qwen2.5-Coder-32B-Instruct [pr | 0]

@saidsef saidsef merged commit c822b8f into main Jan 25, 2025
7 checks passed
@saidsef saidsef deleted the dependabot-npm_and_yarn-opentelemetry-sdk-trace-node-1.30.1 branch January 25, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant