Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in release build on certain runtime combinations #4

Closed

Conversation

kryksyh
Copy link
Collaborator

@kryksyh kryksyh commented Nov 10, 2024

Fix: #3

https://github.com/microsoft/STL/wiki/Changelog#vs-2022-1710

Fixed bugs:
Fixed mutex's constructor to be constexpr. #3824 #4000 #4339
Note: Programs that aren't following the documented restrictions on binary compatibility may encounter null dereferences in mutex machinery. You must follow this rule:
When you mix binaries built by different supported versions of the toolset, the Redistributable version must be at least as new as the latest toolset used by any app component.

You can define _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR as an escape hatch.

@saintmatthieu
Copy link
Owner

Sorry @kryksyh , I merged your other PR without realizing that it was based on this one. I suppose this one should be discarded now ?

@kryksyh
Copy link
Collaborator Author

kryksyh commented Nov 10, 2024

Yep, we can close it.

@kryksyh kryksyh closed this Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release-build Vamp plugin doesn't get loaded (Windows)
2 participants