Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ci): #4 #6

Merged
merged 1 commit into from
Jul 11, 2023
Merged

refactor(ci): #4 #6

merged 1 commit into from
Jul 11, 2023

Conversation

a01sa01to
Copy link
Member

No description provided.

@a01sa01to a01sa01to requested a review from sor4chi July 3, 2023 01:43
@a01sa01to a01sa01to self-assigned this Jul 3, 2023
@a01sa01to a01sa01to linked an issue Jul 3, 2023 that may be closed by this pull request
CI の改善 #4
Closed
@sor4chi
Copy link
Member

sor4chi commented Jul 3, 2023

コミットメッセージもうちょい詳しく書いてくれ

@a01sa01to
Copy link
Member Author

えー、 #4 をみてくれ

@sor4chi
Copy link
Member

sor4chi commented Jul 3, 2023 •
edited
Loading

gitとgithubは違うのでgithub前提のコミットメッセージはよくないんじゃない？
たとえば「perf(ci): pnpmのキャッシュ周りのワークフローの挙動改善 #4」とか

@sor4chi sor4chi added the 開発環境 開発環境への機能追加・修正 label Jul 3, 2023
@a01sa01to
Copy link
Member Author

a01sa01to commented Jul 3, 2023 •
edited
Loading

なるほど...？ (GitHub Actions 使ってる時点で GitHub 前提な気はするけど)

@a01sa01to
refactor(ci): #4
b25a055 
- checkout処理の重複を削除

- Cacheをsetup-nodeにお任せ

- matrixを定義
@a01sa01to a01sa01to mentioned this pull request Jul 3, 2023
Closed
@a01sa01to a01sa01to merged commit a89c632 into main Jul 11, 2023
@a01sa01to
Copy link
Member Author

(Discord 上で議論しました)

@a01sa01to a01sa01to deleted the refactor/ci branch July 11, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sor4chi sor4chi Awaiting requested review from sor4chi

Assignees

@a01sa01to a01sa01to

Labels
開発環境 開発環境への機能追加・修正
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI の改善
2 participants
@a01sa01to @sor4chi