Change to embedded-graphics-core and update embedded-hal #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sajattack
requested changes
Sep 23, 2023
sajattack
reviewed
Mar 14, 2024
| @@ -117,7 +117,7 @@ where | |||
|
|
|||
| pub fn hard_reset<DELAY>(&mut self, delay: &mut DELAY) -> Result<(), ()> | |||
| where | |||
| DELAY: DelayMs<u8>, | |||
| DELAY: DelayNs, | |||
There was a problem hiding this comment.
What is the reason for changing to DelayNs? I think maybe not all devices support nanosecond resolution and we definitely don't need it here.
There was a problem hiding this comment.
Because it is the only trait which can be implemented in 1.0.0 if I haven't missed something.
sajattack
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use embedded-graphics-core 0.4 and embedded-hal 1.0.0-rc.1