-
-
Notifications
You must be signed in to change notification settings - Fork 954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAK-42608 Samigo display user notifications for available assessments #11943
Conversation
4e7062f
to
2e74226
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this PR. You've delved into some challenging code here. So, apart from my pedantic commit suggestions I'd suggest that you add a service method for generating those event reference strings. I see that pattern repeated so many times in the samigo code base and it would be a great improvement if we made a method to return that reference.
...app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/EditAssessmentListener.java
Outdated
Show resolved
Hide resolved
...app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/EditAssessmentListener.java
Outdated
Show resolved
Hide resolved
...app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/EditAssessmentListener.java
Outdated
Show resolved
Hide resolved
...app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/EditAssessmentListener.java
Outdated
Show resolved
Hide resolved
.../src/java/org/sakaiproject/tool/assessment/ui/listener/author/PublishAssessmentListener.java
Outdated
Show resolved
Hide resolved
.../java/org/sakaiproject/tool/assessment/ui/listener/author/SavePublishedSettingsListener.java
Outdated
Show resolved
Hide resolved
.../java/org/sakaiproject/tool/assessment/ui/listener/author/SavePublishedSettingsListener.java
Outdated
Show resolved
Hide resolved
.../java/org/sakaiproject/tool/assessment/ui/listener/author/SavePublishedSettingsListener.java
Outdated
Show resolved
Hide resolved
.../java/org/sakaiproject/tool/assessment/ui/listener/author/SavePublishedSettingsListener.java
Outdated
Show resolved
Hide resolved
.../java/org/sakaiproject/tool/assessment/ui/listener/author/SavePublishedSettingsListener.java
Outdated
Show resolved
Hide resolved
…/listener/author/EditAssessmentListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/EditAssessmentListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/EditAssessmentListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/EditAssessmentListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/PublishAssessmentListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/SavePublishedSettingsListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/SavePublishedSettingsListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/SavePublishedSettingsListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/SavePublishedSettingsListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/SavePublishedSettingsListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/PublishAssessmentListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/PublishAssessmentListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/PublishAssessmentListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/RepublishAssessmentListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/RepublishAssessmentListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/RepublishAssessmentListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/RepublishAssessmentListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/RepublishAssessmentListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/RepublishAssessmentListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/RepublishAssessmentListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/RepublishAssessmentListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/SavePublishedSettingsListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/SavePublishedSettingsListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/SavePublishedSettingsListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/SavePublishedSettingsListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/SavePublishedSettingsListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/SavePublishedSettingsListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/SavePublishedSettingsListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/SavePublishedSettingsListener.java Co-authored-by: Adrian Fish <[email protected]>
…/listener/author/SavePublishedSettingsListener.java Co-authored-by: Adrian Fish <[email protected]>
...rc/java/org/sakaiproject/tool/assessment/ui/listener/author/RepublishAssessmentListener.java
Outdated
Show resolved
Hide resolved
…/listener/author/RepublishAssessmentListener.java
...rc/java/org/sakaiproject/tool/assessment/ui/listener/author/RepublishAssessmentListener.java
Outdated
Show resolved
Hide resolved
…/listener/author/RepublishAssessmentListener.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that'll do. Building those references, drying out that part of the code, that can wait. Thanks.
fix: lookup eventTrackingService via ComponentManager
Thanks for your input and review! I am not sure how to approach a service method for reference building. For me it would make sense to place it in class AssessmentService. In a short search i found 6 possible references for events. Are there any missing? EVENT_ASSESSMENT_AVAILABLE |
Don't worry about it for now. It's a refactor we can do later. Let's get your change in so it can be tested out. Thanks for the work - the notifications stuff has quite a few moving parts. |
…#11943) Co-authored-by: Adrian Fish <[email protected]> (cherry picked from commit 14727b9)
This implementation does consider delays and exceptions for users/groups