Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAK-49908 Remove DBCP And Tomcat JDBC #12472

Merged
merged 3 commits into from
Apr 3, 2024
Merged

SAK-49908 Remove DBCP And Tomcat JDBC #12472

merged 3 commits into from
Apr 3, 2024

Conversation

ottenhoff
Copy link
Contributor

No description provided.

@ottenhoff ottenhoff changed the title Remove DBCP And Tomcat JDBC SAK-49908 Remove DBCP And Tomcat JDBC Mar 29, 2024
@ottenhoff ottenhoff marked this pull request as ready for review March 29, 2024 14:24
ern
ern approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@ern ern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM removes db connection pooling libs that haven't been used in a very long time!!
👍

@ern
Copy link
Contributor

ern commented Apr 3, 2024

needs a rebase

@ottenhoff ottenhoff merged commit 8a7bd19 into sakaiproject:master Apr 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ern ern ern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ottenhoff @ern