Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-49927 Discussions: use sakai-user-photo webcomponent #12484

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

ottenhoff
Copy link
Contributor

Also remove old qtip

@ottenhoff ottenhoff requested a review from hornersa April 3, 2024 19:12
@ottenhoff
Copy link
Contributor Author

This is a good example as to how nice web components are!

Copy link
Contributor

@hornersa hornersa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied this directly to my own instance of 23.x. Though initially surprised by the change in size and outline of the profile photo, it makes sense and works.

@ottenhoff ottenhoff merged commit 3fcc8b7 into sakaiproject:master Apr 3, 2024
5 checks passed
ern pushed a commit that referenced this pull request Aug 15, 2024
(cherry picked from commit 3fcc8b7)

 Conflicts:
	msgcntr/messageforums-app/src/webapp/jsp/privateMsg/pvtMsgDetail.jsp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants