SAK-47101 Sitestats Overlapping presences #12485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stetsche
commented
Apr 4, 2024
sitestats/sitestats-impl/src/test/org/sakaiproject/sitestats/test/StatsUpdateManagerTest.java
Outdated
Show resolved
Hide resolved
sitestats/sitestats-impl/src/test/org/sakaiproject/sitestats/test/StatsUpdateManagerTest.java
Show resolved
Hide resolved
stetsche
commented
Apr 4, 2024
sitestats/sitestats-impl/src/java/org/sakaiproject/sitestats/impl/PresenceConsolidation.java
Outdated
Show resolved
Hide resolved
sitestats/sitestats-impl/src/test/org/sakaiproject/sitestats/test/PresenceRecordTest.java
Show resolved
Hide resolved
sitestats/sitestats-impl/src/test/org/sakaiproject/sitestats/test/StatsUpdateManagerTest.java
Outdated
Show resolved
Hide resolved
stetsche
commented
Apr 4, 2024
sitestats/sitestats-impl/src/java/org/sakaiproject/sitestats/impl/PresenceConsolidation.java
Outdated
Show resolved
Hide resolved
stetsche
commented
Apr 4, 2024
sitestats/sitestats-impl/src/java/org/sakaiproject/sitestats/impl/PresenceConsolidation.java
Outdated
Show resolved
Hide resolved
stetsche
commented
Apr 4, 2024
sitestats/sitestats-impl/src/java/org/sakaiproject/sitestats/impl/PresenceRecord.java
Show resolved
Hide resolved
sitestats/sitestats-impl/src/java/org/sakaiproject/sitestats/impl/PresenceRecord.java
Show resolved
Hide resolved
frasese
reviewed
Apr 4, 2024
sitestats/sitestats-impl/src/java/org/sakaiproject/sitestats/impl/StatsUpdateManagerImpl.java
Outdated
Show resolved
Hide resolved
ottenhoff
reviewed
Apr 4, 2024
sitestats/sitestats-impl/src/java/org/sakaiproject/sitestats/impl/PresenceConsolidation.java
Show resolved
Hide resolved
stetsche
force-pushed
the
SAK-47101
branch
2 times, most recently
from
4f62d5f to
2b21a00
Compare
|
Nice work Markus, thanks for the unit tests 👍 |
|
thank you for the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sakaiproject.atlassian.net/browse/SAK-47101