SAK-50903 Assignments a new assignment using groups should emit an asn.new.assignment event #13234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jkjanetschek We note that you were the last person who was playing this part. Could you review the changes uploaded? |
|
@susowrc Yes, I was working on this code area when I worked on SAK-45992. Back then, I did not switch EVENT_UPDATE_ASSIGNMENT_ACCESS to EVENT_ADD_ASSIGNMENT to change as little as possible while fixing SAK-45992. As I see it, everything related to UserNotifications works fine with your changes. |
ern
changed the title
ern
reviewed
Jan 27, 2025
| @@ -9105,7 +9105,7 @@ private void post_save_assignment(RunData data, String postOrSave) { | |||
| if (aGroups.size() != 0) { | |||
| // If already open | |||
| if (openTime.isBefore(Instant.now())) { | |||
| eventTrackingService.post(eventTrackingService.newEvent(AssignmentConstants.EVENT_UPDATE_ASSIGNMENT_ACCESS, assignmentReference, true)); | |||
| eventTrackingService.post(eventTrackingService.newEvent(AssignmentConstants.EVENT_ADD_ASSIGNMENT, assignmentReference, true)); | |||
There was a problem hiding this comment.
this appears to be the same logic in the else so the if can be simplified
There was a problem hiding this comment.
Yes, we noticed that too. We didn't want to manipulate any more code than necessary. I have made the changes and uploaded them. Thank you.
…tes an asn.new.assignment event, but this does not happen when putting it to selected groups.
jesusmmp
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SAK-50903 Creating a new assignment and putting it to site users creates an asn.new.assignment event, but this does not happen when putting it to selected groups.
https://sakaiproject.atlassian.net/browse/SAK-50903