Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint config and enable to run test code #1

Merged
merged 3 commits into from
May 13, 2016

Conversation

joker1007
Copy link
Contributor

Changes

  • Add endpoint config in order to use dynamodb-local.
  • Add primary_key, sort_key config because createTable needs them
  • Use dynamodb-local when developer run test.
  • Fix createTable because current version doesn't set necessary parameters.
  • Change gem task dependency from build to assemble
    • because that If developer doesn't have dynamodb-local, he cannot build gem, avoid it.

@sakama
Copy link
Owner

sakama commented May 11, 2016

Thank you for your PR.
I have 1 question. primary_key and primary_key_type are defined as non-optional string.
I think they're unnecessary when user doesn't use auto_create_table. So both of them can be defined as Optional.

@joker1007
Copy link
Contributor Author

@sakama
You are right. I fixed it.
Could you review again?

@sakama sakama merged commit 172cc3c into sakama:master May 13, 2016
@sakama
Copy link
Owner

sakama commented May 13, 2016

Thanks! I merged.
Sorry I took a long time.

@joker1007 joker1007 deleted the add-endpoint branch May 13, 2016 07:22
@sakama
Copy link
Owner

sakama commented May 13, 2016

I released v0.1.0 so you can download it from rubygems finally.
Cc: @satoshihirose @YutaroSoejima

xuantuan58 pushed a commit to xuantuan58/embulk-output-dynamodb that referenced this pull request Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants