Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 4 Added Markdown Example #5

Merged
merged 3 commits into from
Oct 3, 2018
Merged

Conversation

Mera-Gangapersaud
Copy link
Contributor

I added the markdown example as specified for issue #4
I also edited the Index.scala file to add the markdown example to the list.
Let me know if anything needs to be added or changed. 😄

@sake92
Copy link
Owner

sake92 commented Oct 2, 2018

@Mera-Gangapersaud this looks great! 😃
Can you just make one tiny change, merge these h2 tags:

      h2(s"""## Headers""".md),
      s"""
      Markdown is a simple way to edit text.

as Markdown:

      s"""
      ## Headers
      Markdown is a simple way to edit text.

because you're doubling h2 tags.
TIP: you can also see the site live on Netlify if you click on All checks have passed and then Details.

@sake92
Copy link
Owner

sake92 commented Oct 3, 2018

Merging, thanks! 🙂

@sake92 sake92 merged commit d4a6ce2 into sake92:master Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants