Skip to content

Commit

Permalink
[4.0] th on safari (joomla#28921)
Browse files Browse the repository at this point in the history
* [4.0] th on safari

PR for joomla#28904

This is a test PR for the TH alignment issue with safari. It is a bug in bootstrap that they have fixed and merged but not released yet. See twbs/bootstrap#30323

This PR adds a _temporary_ reboot.css override with the code direct from bootstrap. I can't see any other way to fix this beta blocker.

I do not have access to Safari to test this.

@nikosdion please can you test this

* Update _reboot.scss
  • Loading branch information
brianteeman authored and sakiss committed Oct 16, 2020
1 parent 39248aa commit 1cd7f07
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions administrator/templates/atum/scss/template.scss
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
@import "vendor/bootstrap/modal";
@import "vendor/bootstrap/nav";
@import "vendor/bootstrap/pagination";
@import "vendor/bootstrap/reboot";
@import "vendor/bootstrap/table";

// Blocks
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// Matches default `<td>` alignment by inheriting `text-align`.
// 1. Fix alignment for Safari

th {
text-align: inherit;
text-align: -webkit-match-parent; // 1
}

0 comments on commit 1cd7f07

Please sign in to comment.