Skip to content

Fix Segment app issues & AvaTax app migration script #1501

Fix Segment app issues & AvaTax app migration script

Fix Segment app issues & AvaTax app migration script #1501

Triggered via pull request January 28, 2025 12:35
Status Failure
Total duration 3m 4s
Artifacts

main.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

4 errors and 10 warnings
src/modules/tracking-events/track-event.use-case.test.ts > TrackEventUseCase > successfully tracks event: apps/segment/src/modules/tracking-events/track-event.use-case.test.ts#L45
AssertionError: expected "spy" to be called with arguments: [ { …(4) } ] Received: 1st spy call: Array [ Object { "event": "Saleor Order Updated", "issuedAt": "2025-01-07", "properties": Object { "channel_id": "channel-id", - "coupon": undefined, "currency": "USD", "discount": 7, + "email": "user-email", "order_id": "order-id", "products": Array [ Object { "category": "categoryName", - "coupon": undefined, "name": "productName", "price": 37, "product_id": "line-id", "quantity": 1, "sku": "sku", "variant": "variantName", }, ], "shipping": 5, "tax": 0.21, "total": 37, }, "user": Object { "id": "user-email", "type": "logged", }, }, ] Number of calls: 1 ❯ src/modules/tracking-events/track-event.use-case.test.ts:45:39
src/modules/tracking-events/tracking-events.test.ts > trackingEventFactory > should create event for order updated with user email if user information is present: apps/segment/src/modules/tracking-events/tracking-events.test.ts#L53
Error: Snapshot `trackingEventFactory > should create event for order updated with user email if user information is present 1` mismatched - Expected + Received @@ -2,10 +2,11 @@ "issuedAt": "2025-01-07", "payload": { "channel_id": "channel-id", "currency": "USD", "discount": 7, + "email": "user-email", "order_id": "order-id", "products": [ { "category": "categoryName", "name": "productName", ❯ src/modules/tracking-events/tracking-events.test.ts:53:19
test
segment#test:ci: command (/home/runner/work/apps/apps/apps/segment) /home/runner/setup-pnpm/node_modules/.bin/pnpm run test:ci exited (1)
test
Process completed with exit code 1.
lint: packages/webhook-utils/generated/graphql.ts#L1
Run autofix to sort these imports!
lint: packages/webhook-utils/generated/graphql.ts#L3
Expected 1 empty line after import statement not followed by another import
lint: apps/klaviyo/generated/graphql.ts#L1
Run autofix to sort these imports!
lint: apps/klaviyo/generated/graphql.ts#L3
Expected 1 empty line after import statement not followed by another import
lint: apps/klaviyo/src/hooks/useAppApi.ts#L60
React Hook useEffect has missing dependencies: 'appBridgeState?.ready' and 'fetchOptions'. Either include them or remove the dependency array
lint: apps/klaviyo/src/lib/metadata.ts#L26
Potential PII leak: object shorthand property used with object value inside logger arguments. Pass only specific fields from the object to the logger
lint: apps/klaviyo/src/lib/metadata.ts#L26
Potential PII leak: object shorthand property used with unknown value inside logger arguments. Please use only known values
lint: apps/products-feed/generated/graphql.ts#L1
Run autofix to sort these imports!
lint: apps/products-feed/generated/graphql.ts#L3
Expected 1 empty line after import statement not followed by another import