Skip to content

Commit

Permalink
fixes after CR
Browse files Browse the repository at this point in the history
  • Loading branch information
krzysztofzuraw committed Oct 28, 2024
1 parent ef1bc86 commit f359864
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 4 deletions.
2 changes: 1 addition & 1 deletion apps/avatax/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ The app has an example environment for `localhost` in `environments/localhost.br
> This section refers to apps hosted by Saleor or using REST APL. If you self host AvaTax app you need to write your own logic for updating migration scripts.
> See [How to update app webhooks](https://docs.saleor.io/docs/3.x/developer/extending/apps/updating-app-webhooks) for more info.
You need to set `REST_APL_TOKEN` & `REST_APL_ENDPOINT` in our `.env` file first. Set `DANGEROUS_ENABLE_MIGRATION_CONSOLE_LOGGER` to see migration results in your shell.
You need to set `REST_APL_TOKEN` & `REST_APL_ENDPOINT` in our `.env` file first.

Test migration with dry run, operation will not modify any data:

Expand Down
2 changes: 0 additions & 2 deletions apps/avatax/src/env.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ export const env = createEnv({
DYNAMODB_LOGS_TABLE_NAME: z.string().optional(),
E2E_USER_NAME: z.string().optional(),
E2E_USER_PASSWORD: z.string().optional(),
// ENABLE_MIGRATION_CONSOLE_LOGGER: booleanSchema.optional().default("false"),
FF_ENABLE_EXPERIMENTAL_LOGS: booleanSchema.optional().default("false"),
FILE_APL_PATH: z.string().optional(),
MANIFEST_APP_ID: z.string().optional().default("saleor.app.avatax"),
Expand Down Expand Up @@ -59,7 +58,6 @@ export const env = createEnv({
DYNAMODB_LOGS_TABLE_NAME: process.env.DYNAMODB_LOGS_TABLE_NAME,
E2E_USER_NAME: process.env.E2E_USER_NAME,
E2E_USER_PASSWORD: process.env.E2E_USER_PASSWORD,
// ENABLE_MIGRATION_CONSOLE_LOGGER: process.env.ENABLE_MIGRATION_CONSOLE_LOGGER,
ENV: process.env.ENV,
FF_ENABLE_EXPERIMENTAL_LOGS: process.env.FF_ENABLE_EXPERIMENTAL_LOGS,
FILE_APL_PATH: process.env.FILE_APL_PATH,
Expand Down
1 change: 0 additions & 1 deletion apps/avatax/turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
"AWS_SECRET_ACCESS_KEY",
"DYNAMODB_LOGS_ITEM_TTL_IN_DAYS",
"DYNAMODB_LOGS_TABLE_NAME",
"ENABLE_MIGRATION_CONSOLE_LOGGER",
"FF_ENABLE_EXPERIMENTAL_LOGS",
"FILE_APL_PATH",
"MANIFEST_APP_ID",
Expand Down

0 comments on commit f359864

Please sign in to comment.