Map customer code to a metadata field in the Taxes App #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4313ea0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
peelar
changed the title
peelar
changed the title
|
Please remember about the docs (or add in issue to update them later) |
peelar
force-pushed
the
del-59-map-customer-code-to-a-custom-field-in-the-taxes-app
branch
from
f727049 to
9b80364
Compare
witoszekdev
approved these changes
Feb 1, 2024
| @@ -27,6 +27,7 @@ export class AvataxEntityTypeMatcher { | |||
| return result.value?.[0].code || this.returnFallback(); | |||
| } | |||
|
|
|||
| // Now that we get the customer code from user metadata, maybe we should get the entity code from the same place? | |||
There was a problem hiding this comment.
Question: should it be marked as TODO?
krzysztofzuraw
approved these changes
Feb 1, 2024
Cloud11PL
approved these changes
Feb 1, 2024
Co-authored-by: Jonatan Witoszek <[email protected]>
Co-authored-by: Jonatan Witoszek <[email protected]>
krzysztofwolski
deleted the
del-59-map-customer-code-to-a-custom-field-in-the-taxes-app
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Taxes App synchronizes a group of fields from Saleor to an AvaTax transaction. Some of these fields are used to determine the tax value (e.g. the customer code).
The general approach is to use the Saleor field that matches the purpose of the AvaTax field the most. However, users sometimes want to override that value with their own. This usually comes into play when multiple other systems (where e.g. one system manages the customers) collaborate on the tax calculation.
Scope of the PR
UserFragmenteverywhereChecklist
Note
This PR isn't breaking. If the metadata field is not found, the app will fall back as usual. We will add the migrations next week.