Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avatax shipping line #1215

Merged
merged 4 commits into from
Feb 23, 2024
Merged

feat: avatax shipping line #1215

merged 4 commits into from
Feb 23, 2024

Conversation

peelar
Copy link
Member

@peelar peelar commented Feb 21, 2024

ported this PR from Taxes App

@peelar peelar requested a review from a team as a code owner February 21, 2024 12:29
@peelar peelar requested a review from a team February 21, 2024 12:29
Copy link

changeset-bot bot commented Feb 21, 2024

🦋 Changeset detected

Latest commit: d51f1e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
app-avatax Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-avatax ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 0:13am
saleor-app-cms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 0:13am
saleor-app-crm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 0:13am
saleor-app-data-importer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 0:13am
saleor-app-emails-and-messages ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 0:13am
saleor-app-invoices ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 0:13am
saleor-app-klaviyo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 0:13am
saleor-app-products-feed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 0:13am
saleor-app-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 0:13am
saleor-app-segment ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 0:13am
saleor-app-slack ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 0:13am
saleor-app-taxes ✅ Ready (Inspect) Visit Preview Feb 23, 2024 0:13am

shipping_tax_rate: 0,
};
}
// why is tax rate 0?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what should we do with this comment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peelar
Copy link
Member Author

peelar commented Feb 22, 2024

@lkostrowski the tests are failing:

 WARNING  Issues occurred when constructing package graph. Turbo will function, but some features may not be available:  1 error occurred:
	* error performing lockfile operation: Unable to find resolved version for @opentelemetry/api@link:node_modules/@opentelemetry/api in apps/slack


• Packages in scope: @saleor/apps-logger, @saleor/apps-otel, @saleor/apps-shared, @saleor/apps-ui, @saleor/e2e, @saleor/react-hook-form-macaw, @saleor/trpc, @saleor/webhook-utils, app-avatax, app-taxjar, cms-v2, crm, data-importer, emails-and-messages, eslint-config-saleor, invoices, klaviyo, products-feed, search, segment, slack, taxes

I tried to trigger the workflow again but it didn't help. Any idea what can I do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants