Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor logger #1635

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Refactor logger #1635

merged 3 commits into from
Oct 25, 2024

Conversation

krzysztofzuraw
Copy link
Member

Scope of the PR

Renamed exported logger to rootLogger so we avoid collision of names when using logger in monorepo. Also createLogger function has been removed in favour of app defining it in their codebase.

Related issues

Checklist

@krzysztofzuraw krzysztofzuraw requested review from a team as code owners October 25, 2024 07:28
@krzysztofzuraw krzysztofzuraw requested review from a team and lkostrowski October 25, 2024 07:28
Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: 356740d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
products-feed Patch
klaviyo Patch
app-avatax Patch
cms-v2 Patch
search Patch
smtp Patch
@saleor/apps-logger Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-avatax ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 7:34am
saleor-app-cms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 7:34am
saleor-app-klaviyo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 7:34am
saleor-app-products-feed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 7:34am
saleor-app-search 🛑 Canceled (Inspect) 💬 Add feedback Oct 25, 2024 7:34am
saleor-app-smtp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 7:34am

@krzysztofzuraw krzysztofzuraw merged commit d088ef3 into main Oct 25, 2024
17 checks passed
@krzysztofzuraw krzysztofzuraw deleted the refactor-logger branch October 25, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants