Add OTEL & improve logs in Segment app #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cd4c973 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
witoszekdev
approved these changes
Jan 8, 2025
Comment on lines
+54
to
+56
| logger.warn( | ||
| "Segment write key is not set in app configuration. Contact client to fix the issue.", | ||
| ); |
There was a problem hiding this comment.
question: do we want to treat broken app config as warning for our logs? I think this is fine for now, but imho it's not really scalable and client logs would be better ;)
There was a problem hiding this comment.
In other PR I disable webhooks is there is no key so hopefully there won't be many such situations but I agree - we should let client know (client logs or maybe emails etc.)
lkostrowski
added a commit
that referenced
this pull request
Jan 13, 2025
* log suspicious taxes calculation (#1658) * fix log (#1660) * Use vercel log drain in merchant apps (#1657) * Use vercel log drain * Add changeset * improve log for non zero line (#1663) * Bring back Segment app to monorepo (#1665) * Fix deployment of Segment app (#1666) * Add setup node to GHA workflow (#1673) * Add Sentry to Segment app (#1671) * Add OTEL & improve logs in Segment app (#1675) * Fixed app version send to Segment & how we send events (#1676) * Add use-case to Segment app (#1677) * Initially disable Segment app webhooks (#1678) * Add README to Segment app (#1683) * Improve Segment app logo (#1682) * Fix missing cache for test workflow (#1685) * Add new Vercel log limit (#1684) * Run autofix for monorepo (#1681) * Fix code scan issue with ALLOWED_DOMAIN_PATTERN regex (#1687) --------- Co-authored-by: Lukasz Ostrowski <[email protected]> Co-authored-by: Paweł Chyła <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of the PR
Related issues
Checklist