Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: first start addding shipping_label attribute #1713

Merged
merged 9 commits into from
Jan 28, 2025

Conversation

JannikZed
Copy link
Contributor

@JannikZed JannikZed commented Jan 24, 2025

Scope of the PR

Adding support for shipping_label in the attributes mapping.
Docs: https://support.google.com/merchants/answer/6324504?hl=en

Checklist

@JannikZed JannikZed requested a review from a team as a code owner January 24, 2025 14:51
Copy link

changeset-bot bot commented Jan 24, 2025

🦋 Changeset detected

Latest commit: 0bc3bc5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
products-feed Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 24, 2025

@JannikZed is attempting to deploy a commit to the Saleor Commerce Team on Vercel.

A member of the Team first needs to authorize it.

@JannikZed
Copy link
Contributor Author

this PR is tested with the merchant center and allows us to setup free shipping just for specific items.

@krzysztofzuraw
Copy link
Member

@JannikZed can you fix errors from lint & test workflows 🙏🏻

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 20 lines in your changes missing coverage. Please review.

Project coverage is 44.06%. Comparing base (34da7f1) to head (0bc3bc5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...s-feed/src/modules/google-feed/product-to-proxy.ts 20.00% 8 Missing ⚠️
...dules/app-configuration/attribute-mapping-form.tsx 0.00% 7 Missing ⚠️
apps/products-feed/src/pages/configuration.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1713      +/-   ##
==========================================
- Coverage   44.06%   44.06%   -0.01%     
==========================================
  Files         643      643              
  Lines      296028   296058      +30     
  Branches     1997     2000       +3     
==========================================
+ Hits       130434   130444      +10     
- Misses     165188   165208      +20     
  Partials      406      406              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JannikZed
Copy link
Contributor Author

@krzysztofzuraw not sure, how the code coverage did decrease? Tests are in there.. so maybe you can take a look about that. All other checks pass.

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-avatax ✅ Ready (Inspect) Visit Preview Jan 28, 2025 10:47am
saleor-app-cms ✅ Ready (Inspect) Visit Preview Jan 28, 2025 10:47am
saleor-app-klaviyo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 10:47am
saleor-app-products-feed ✅ Ready (Inspect) Visit Preview Jan 28, 2025 10:47am
saleor-app-search ✅ Ready (Inspect) Visit Preview Jan 28, 2025 10:47am
saleor-app-segment ✅ Ready (Inspect) Visit Preview Jan 28, 2025 10:47am
saleor-app-smtp ✅ Ready (Inspect) Visit Preview Jan 28, 2025 10:47am

@krzysztofzuraw krzysztofzuraw merged commit 6c4e330 into saleor:main Jan 28, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants