Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding native redis APL support for all apps #1719

Closed
wants to merge 2 commits into from

Conversation

JannikZed
Copy link
Contributor

@JannikZed JannikZed commented Jan 29, 2025

Scope of the PR

adding native redis APL support for all apps. No breaking changes.

Related issues

Checklist

@JannikZed JannikZed requested a review from a team as a code owner January 29, 2025 09:04
Copy link

changeset-bot bot commented Jan 29, 2025

🦋 Changeset detected

Latest commit: f507082

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
products-feed Minor
klaviyo Minor
segment Minor
app-avatax Minor
cms-v2 Minor
search Minor
smtp Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 29, 2025

@JannikZed is attempting to deploy a commit to the Saleor Commerce Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 13.97849% with 80 lines in your changes missing coverage. Please review.

Project coverage is 44.05%. Comparing base (6c4e330) to head (f507082).

Files with missing lines Patch % Lines
apps/segment/src/saleor-app.ts 0.00% 19 Missing ⚠️
apps/products-feed/src/saleor-app.ts 0.00% 17 Missing ⚠️
apps/avatax/saleor-app.ts 0.00% 16 Missing ⚠️
apps/search/saleor-app.ts 22.22% 14 Missing ⚠️
apps/smtp/src/saleor-app.ts 17.64% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1719      +/-   ##
==========================================
- Coverage   44.06%   44.05%   -0.01%     
==========================================
  Files         643      643              
  Lines      296058   296149      +91     
  Branches     2000     2002       +2     
==========================================
+ Hits       130444   130455      +11     
- Misses     165208   165288      +80     
  Partials      406      406              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkostrowski
Copy link
Member

@JannikZed please keep that on the fork. You can remove SaleorCloud code from the bundle and use whatever APL you need. This repository is a direct source of Saleor Cloud apps and we don't want it to contain code that will not be used (but need to be maintained).

@JannikZed JannikZed deleted the redis-apl-all-apps branch January 29, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants