Fix #274 - Fix Views HTML Entities Which Encode UTF Characters Incorrectly #403 #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgorod
reviewed
Jun 14, 2024
| @@ -322,6 +322,10 @@ public function fetch( | |||
| $listData[$key]['assigned_user_name']['user_name'] = $user->user_name ?? ''; | |||
| $listData[$key]['assigned_user_name']['user_id'] = $record['assigned_user_id']; | |||
| $listData[$key]['module_name'] = $panelToModuleName[$listData[$key]['panel_name']]; | |||
| $listData[$key]['descrition'] = html_entity_decode($listData[$key]['descrition'] ?? '', ENT_QUOTES); | |||
There was a problem hiding this comment.
Is this really descrition instead of description?
There was a problem hiding this comment.
Typo has been fixed.
6 tasks
yunusyerli1
force-pushed
the
bugfix_274
branch
from
6b94b52 to
ff1ed1d
Compare
|
I tested this solution on version 8.7.1, and it doesn't work for the description fields. |
|
This fix doesn't work for me. No errors but errors in accented characters remains... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See the issue #274 for more details about the issue.
This is the second commit of #403.
Motivation and Context
How To Test This
a. For example, change the company name that is referenced in a Call. (Like adding åäö or other letters)
Types of changes
Final checklist