Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default for Campaign Type field causes incorrect wizard #2009

Open
JimMackin opened this issue Aug 22, 2016 · 2 comments
Open

Default for Campaign Type field causes incorrect wizard #2009

JimMackin opened this issue Aug 22, 2016 · 2 comments
Labels
Priority:Moderate Issues & PRs that are minor; broken styling, cosmetic, warnings - there are practical workarounds Type: Bug Bugs within the core SuiteCRM codebase

Comments

@JimMackin
Copy link
Contributor

Issue

The campaign type field is partially used to decide which template to show for the campaign wizard. A default value for this field can cause the wrong wizard to be shown (asking for an email template for a non email campaign for example.

Expected Behavior

Non email wizard should be displayed.

Actual Behavior

Newsletter wizard is displayed instead.

Possible Fix

Fix the check around line 120 of modules/Campaigns/WizardNewsletter.php to always use the wizardtype from request if it exists.

Steps to Reproduce

  1. Set the default for campaign_type to be newsletter
  2. Create a new campaign choosing the non email option
  3. Observe the campaign wizard - it's showing the newsletter version.

Context

Your Environment

  • SuiteCRM Version used:
  • Browser name and version (e.g. Chrome Version 51.0.2704.63 (64-bit)):
  • Environment name and version (e.g. MySQL, PHP 7):
  • Operating System and version (e.g Ubuntu 16.04):

Ubuntu 14.04
PHP 5.5.9
MySQL 5.5.50

@JimMackin JimMackin added the Type: Bug Bugs within the core SuiteCRM codebase label Aug 22, 2016
@ijdavie ijdavie added the Priority:Moderate Issues & PRs that are minor; broken styling, cosmetic, warnings - there are practical workarounds label Sep 19, 2016
@Mac-Rae
Copy link
Contributor

Mac-Rae commented Aug 2, 2019

Confirmed in latest 7.10.x

@Kevconry
Copy link

Kevconry commented Feb 1, 2023

Was able to replicate in 7.13.1

serhiisamko091184 added a commit to serhiisamko091184/SuiteCRM that referenced this issue Oct 11, 2024
serhiisamko091184 added a commit to serhiisamko091184/SuiteCRM that referenced this issue Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Moderate Issues & PRs that are minor; broken styling, cosmetic, warnings - there are practical workarounds Type: Bug Bugs within the core SuiteCRM codebase
Projects
None yet
Development

No branches or pull requests

4 participants