Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[language] Hard coded messages in Elasticsearch #6540

Closed
likhobory opened this issue Nov 28, 2018 · 1 comment
Closed

[language] Hard coded messages in Elasticsearch #6540

likhobory opened this issue Nov 28, 2018 · 1 comment
Labels
Area: Language Issues & PRs that are confirmed as issues with language & translation within the core Priority:Moderate Issues & PRs that are minor; broken styling, cosmetic, warnings - there are practical workarounds Type: Bug Bugs within the core SuiteCRM codebase
Milestone
7.11.4

Comments

@likhobory
Copy link
Contributor

An error has occurred while performing the search. Your query syntax might not be valid.
https://github.com/salesagility/SuiteCRM/blob/develop/lib/Search/UI/SearchThrowableHandler.php#L117

Unable to find the requested SearchEngine. Try performing the search again.
https://github.com/salesagility/SuiteCRM/blob/develop/lib/Search/UI/SearchThrowableHandler.php#L119

Failed to connect to the Elasticsearch server.
https://github.com/salesagility/SuiteCRM/blob/develop/lib/Search/UI/SearchThrowableHandler.php#L121

An error internal to the Search has occurred.
https://github.com/salesagility/SuiteCRM/blob/develop/lib/Search/UI/SearchThrowableHandler.php#L123

An unknown error has occurred while performing the search.
https://github.com/salesagility/SuiteCRM/blob/develop/lib/Search/UI/SearchThrowableHandler.php#L125

Contact an administrator if the problem persists. More information available in the logs.
https://github.com/salesagility/SuiteCRM/blob/develop/lib/Search/UI/SearchThrowableHandler.php#L171

ms
https://github.com/salesagility/SuiteCRM/blob/develop/lib/Search/UI/templates/search.results.tpl#L75

Search Interface
https://github.com/salesagility/SuiteCRM/blob/develop/modules/Administration/Search/view.tpl#L50
@likhobory likhobory mentioned this issue Dec 6, 2018
Open
@Dillon-Brown Dillon-Brown added the Area: Language Issues & PRs that are confirmed as issues with language & translation within the core label Dec 6, 2018
@jack7anderson7 jack7anderson7 added the PR:Community Contribution These are contribution made by the community label Dec 7, 2018
@pgorod
Copy link
Contributor

pgorod commented Dec 7, 2018

While somebody is fixing this, please improve this string also:

https://github.com/salesagility/SuiteCRM/blob/develop/modules/Administration/language/en_us.lang.php#L972

The Wrapper is a programming concept, it shouldn't be in the UI, much less on a help string.

This probably isn't worth a separate Issue and PR so I put it here.

@Dillon-Brown Dillon-Brown removed PR:Community Contribution These are contribution made by the community labels Dec 7, 2018
@likhobory likhobory mentioned this issue Jan 14, 2019
Closed
@code-ph0y code-ph0y mentioned this issue Jan 25, 2019
Merged
6 tasks
@willrennie willrennie added Type: Bug Bugs within the core SuiteCRM codebase Priority:Moderate Issues & PRs that are minor; broken styling, cosmetic, warnings - there are practical workarounds labels Apr 8, 2019
@Dillon-Brown Dillon-Brown added this to the 7.11.4 milestone Apr 29, 2019
Dillon-Brown added a commit that referenced this issue Apr 29, 2019
@Dillon-Brown
Merge pull request #6843 from code-ph0y/fix/6540_hard_code_messages_e…
b4b930d 
…lasticsearch

Fixed #6540 - Hard coded text to language files
@gymad gymad closed this as completed in 329c47a Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Language Issues & PRs that are confirmed as issues with language & translation within the core Priority:Moderate Issues & PRs that are minor; broken styling, cosmetic, warnings - there are practical workarounds Type: Bug Bugs within the core SuiteCRM codebase
Projects
None yet
Milestone
7.11.4
Development

No branches or pull requests
6 participants
@willrennie @likhobory @pgorod @Dillon-Brown @jack7anderson7 @Mac-Rae