Error in Browsers console after adding tabs to Quickcreate

[SinergiaCRM]

After setting a tab configuration in a quickcreate view of a module, it appears an error in the browser Console:

Issue

There is some errors regarding the use of tabs in a quickcreate view.

This error may cause other JS scripts to not execute.

Expected Behavior

There shouldn't be any error.

Actual Behavior

Error appears in console

Possible Fix

Steps to Reproduce

1. Add a panel in the QuickCreate view of the Accounts module
2. After saving the view, change the "Panel" to "Tab" configuration
3. Go to the Quickcreateview of Accounts (Inside an Account, the Member Organization subpanel)
4. Open the browser console and see the error

Context

Your Environment

SuiteCRM Version used: 7.11.21
Browser name and version: Chrome
Environment name and version (e.g. MySQL, PHP 7): PHP 7
Operating System and version (e.g Ubuntu 16.04): Ubuntu

[lukio]

The problem remains at 8.x suitecrm when working with legacy layout.

[lukio]

Duplicated ticket #8780

[lukio]

@SinergiaCRM I found that the name of the function selectTabOnError has been declared twice at the theme.

themes/suite8/include/DetailView/DetailView.tpl:                    let selectTabOnError = function(tab) {
themes/suite8/include/EditView/EditView.tpl:    var selectTabOnError = function(tab) {

If I change the definition of the function from let to var it does not throws the error on the javascript console.

[SinergiaCRM]

Thanks @lukio. This sounds interesting. This error has been here for a while already. We will try it out.

If you are certain, you could open a PR with the proposed fix.

[lukio]

Thanks @lukio. This sounds interesting. This error has been here for a while already. We will try it out.

If you are certain, you could open a PR with the proposed fix.

@SinergiaCRM I opened a new PR with the propoosed fix.

#9813

[SinergiaCRM]

Hi @lukio it seems that the problem persists in the latest version. Could it be due to something else?

[SinergiaCRM]

@jack7anderson7 , I reopened this issue again. The error continues to occur with the change in the definition of the function selectTabOnError from let to var.