New User Group Popup. Popup does not show after creating a user

[QuickCRM]

Issue

When New User Group Popup is checked, a popup is supposed to open when a user is created so that you can select a security group.
It used to work, but no longer works with latest versions of SuiteCRM 10, 11 and 12.
The browser console shows
TypeError: null is not an object (evaluating 'win.focus')
in open_popup function.

Expected Behavior

A popup should open

Actual Behavior

It does not and a javaScript error happens

Possible Fix

Steps to Reproduce

1. make sure New User Group Popup in Security Suite settings
   2.Create a user

Context

Make sure all new users are assigned a security group

Your Environment

• SuiteCRM Version used: 7.10, 7.11, 7.12
• Browser name and version (e.g. Chrome Version 51.0.2704.63 (64-bit)): Chrome, Safari
• Environment name and version (e.g. MySQL, PHP 7): any
• Operating System and version (e.g Ubuntu 16.04): Ubuntu

[urdhvatech]

In Chrome browser if popup is blocked, then window opens successfully. Looks like window.open is considered as popup, and popup is blocked.
If you disable popup blocker of chrome browser, It will work as expected.

[QuickCRM]

That's not it.
Popups are not blocked (for example, you can open a popup to select an account in a contact edit view).
This issue is specific to selecting a security group after creating a user.
The browser shows a javascript error:
TypeError: null is not an object (evaluating 'win.focus')

[urdhvatech]

Yes, After creating user the security group executes the javascript, which you have mentioned that doesn't work when Popup is blocked.
I will do the PR in a day or so.

[QuickCRM]

I changed the browser settings to authorize popups.
It works now, but I can't understand why this popup was blocked while other popups were not (select any relate field on any module).

[viku3150]

Instead of a popup can we have a modal for the same? In this case whatever be the case, there's no blocking

[urdhvatech]

From version 8, It is now modal box.

[SuiteBot]

This issue has been mentioned on SuiteCRM. There might be relevant details there:

https://community.suitecrm.com/t/hacktoberfest-2022/86484/2

[himanshu007-creator]

Hi, i would like to work on this issue