Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8897 - Adding missing relationship for SurveyResponses module #9329

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

SinergiaCRM
Copy link
Contributor

Closes #8897

The records for the related modules Contacts/Accounts, don't appear in some of the views Surveys views. Both in SurveyResponses ListView and the SurveyResponses Subpanel inside a Survey record.

Description

Due to the issue found in the link above, we found that there are missing some relationships in the definition of the vardef between the modules SurveyResponses and Contacts/Accounts. We add the definition in the vardef definition of the SurveyResponses module.

Motivation and Context

There is a way to define relationship between modules. This PR completes them.

How To Test This

  1. Create a Survey
  2. Create a Response for that Survey
  3. Add a Contact to that Response
  4. Add the column Contact to the Subpanel of the Survey Response module that appear in the Survey module
  5. Check that the Contact doesn't appear in the Subpanel of the Survey Response module inside the Survey Record

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@SinergiaCRM SinergiaCRM changed the base branch from hotfix-7.10.x to hotfix February 25, 2022 05:18
@SinergiaCRM SinergiaCRM changed the title Fixed #8897 - Adding missing relationship for SurveyResponses module Fix #8897 - Adding missing relationship for SurveyResponses module Jun 16, 2022
@SinergiaCRM
Copy link
Contributor Author

Updated commit title

@serhiisamko091184 serhiisamko091184 added Status: Requires Code Review Needs the core team to code review Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Branch:Hotfix labels Feb 2, 2023
@clemente-raposo
Copy link
Contributor

Hi @SinergiaCRM, thank you for your PR

@clemente-raposo clemente-raposo added Status: Requires Testing Requires Manual Testing Status: Passed Code Review Mark issue has passed code review reviewed and removed Status: Requires Code Review Needs the core team to code review labels Mar 3, 2023
Copy link
Contributor

@johnM2401 johnM2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Contact links appear and can be navigated to.

@johnM2401 johnM2401 added Status: Passed Testing and removed Status: Requires Testing Requires Manual Testing labels Apr 11, 2023
@jack7anderson7 jack7anderson7 merged commit 66e2a6d into salesagility:hotfix Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch:Hotfix Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Mark issue has passed code review reviewed Status: Passed Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relationship record's name from Contact/Account doesn't appear in SurveyResponse ListView
5 participants