Fix #9602 - ProspectLists save function has a duplication issue

[eojedapilchik]

The $focus->save() call inside \modules\ProspectLists\Save.php on line 79 is unnecessary.
If there are any after_save logic hooks present on the Prospect List (Target List) module, it will trigger them twice for a target list that is being duplicated, causing undesired results.

Description

This fix is related to this issue: https://github.com/salesagility/SuiteCRM/issues/9602

When a Target List is duplicated there's a check on the \modules\ProspectLists\Save.php that handles adding related records to the Target List being duplicated.
On line 79 of the Save.php there's a call that is redundant to the save method of the focus bean. This causes any after_save logic hook to be triggered twice which is undesirable.

Motivation and Context

This solves redundant after_save logic hooks being triggered on a Target List being duplicated.

How To Test This

1. Create an after_save logic hook on the Target List module.
2. Add a $GLOBALS['log']->fatal('After save Triggered') or any other logic to the after_save logic hook.
3. Create a Target List.
4. On Edit View > Duplicate the target list created in the previous step.
5. Check that the after_save was triggered only once.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

• My code follows the code style of this project found here.
• My change requires a change to the documentation.
• I have read the How to Contribute guidelines.

[SuiteBot]

All committers have signed the CLA.

[jack7anderson7]

Hi @eojedapilchik,

Thanks for your Pull Request.

Could you please update the commit message following the standards shown in our documentation:
https://docs.suitecrm.com/community/contributing-code/bugs/

Thanks,
Jack

[eojedapilchik]

Amended the commit message here: 0733b4a

[serhiisamko091184]

Hello, @eojedapilchik

thanks for contribution,

Would you be so kind also to squash commits in your branch into one (it means to combine multiple commits into single commit)?

Thanks in advance,
Serhii

[eojedapilchik]

@serhiisamko091184 I updated the branch to use only 1 commit, let me know if there's any other requirement to merge it

[clemente-raposo]

LGTM

[johnM2401]

LGTM

Target List Logic Hook now only fires once on Duplication

Also fires once on Normal Creation, (either through Create Action, or through Campaigns Module->Target Lists creation)

Users able to relate items as normal.

Can be merged!