-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #9783 - Compose view quick search for email templates #9784
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ojs87
It looks as though the functionality works well on the Standard Emails->Compose view.
However, If you are on the Compose Email Popup, (ie: Accounts->Activities->Compose Email). selecting an Email Template via the Auto-Complete causes the template to not be applied.
Selecting via standard select Popup:
I believe this may be worth resolving, so as to keep functionality consistent across the CRM.
What are your thoughts?
Thanks!
thanks for testing @johnM2401 I did test this and it worked for me, although there are more issues with the popup than the standard compose, for example closing and reopening the popup seems to break the auto complete. Are you sure it isn't working on the popup compose? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ojs87
Apologies, I've pulled this PR down again and it appears to work as expected on both Compose Popup & Email->Compose Editview
Perhaps something was cached last time around?
Either way, I have Checked on both Firefox & Chromium, LGTM!
Not to worry, I had a feeling you had tested this before and came up with the same issue and I fixed it then, so I just double checked it was still in the PR. Must have been a js caching issue. |
Description
See #9783
Email templates doesn't activate quick search when typing in the field in the Emails module compose view
Motivation and Context
Quick search feature is handy to have on this relate field so that opening the pop-up isn't required
How To Test This
Types of changes
Final checklist