Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9783 - Compose view quick search for email templates #9784

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

ojs87
Copy link
Contributor

@ojs87 ojs87 commented Oct 7, 2022

Description

See #9783

Email templates doesn't activate quick search when typing in the field in the Emails module compose view

Motivation and Context

Quick search feature is handy to have on this relate field so that opening the pop-up isn't required

How To Test This

  1. Go to the Emails module
  2. Click on Compose
  3. In the Email Template Field type "C"
  4. A list of email templates beginning with C should be displayed
  5. No email template options are displayed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@jack7anderson7 jack7anderson7 added Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Branch:Hotfix Hacktoberfest Issues & PRs that count towards Hacktoberfest labels Oct 14, 2022
@clemente-raposo clemente-raposo added Status: Requires Testing Requires Manual Testing Status: Passed Code Review Mark issue has passed code review reviewed and removed Status: Requires Code Review Needs the core team to code review labels Mar 20, 2023
Copy link
Contributor

@johnM2401 johnM2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ojs87

It looks as though the functionality works well on the Standard Emails->Compose view.

However, If you are on the Compose Email Popup, (ie: Accounts->Activities->Compose Email). selecting an Email Template via the Auto-Complete causes the template to not be applied.

Selecting via standard select Popup:
image
image

Selecting via Auto-complete:
image

I believe this may be worth resolving, so as to keep functionality consistent across the CRM.

What are your thoughts?

Thanks!

@johnM2401 johnM2401 added Status: Requires Updates Issues & PRs which requires input or update from the author and removed Status: Requires Testing Requires Manual Testing labels Apr 11, 2023
@ojs87
Copy link
Contributor Author

ojs87 commented Apr 11, 2023

thanks for testing @johnM2401

I did test this and it worked for me, although there are more issues with the popup than the standard compose, for example closing and reopening the popup seems to break the auto complete.

Are you sure it isn't working on the popup compose?

Copy link
Contributor

@johnM2401 johnM2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ojs87

Apologies, I've pulled this PR down again and it appears to work as expected on both Compose Popup & Email->Compose Editview

Perhaps something was cached last time around?

Either way, I have Checked on both Firefox & Chromium, LGTM!

@johnM2401 johnM2401 added Status: Passed Testing and removed Status: Requires Updates Issues & PRs which requires input or update from the author labels Apr 12, 2023
@ojs87
Copy link
Contributor Author

ojs87 commented Apr 12, 2023

Hey @ojs87

Apologies, I've pulled this PR down again and it appears to work as expected on both Compose Popup & Email->Compose Editview

Perhaps something was cached last time around?

Either way, I have Checked on both Firefox & Chromium, LGTM!

Not to worry, I had a feeling you had tested this before and came up with the same issue and I fixed it then, so I just double checked it was still in the PR. Must have been a js caching issue.
Thanks!

@jack7anderson7 jack7anderson7 merged commit 1077ebb into salesagility:hotfix Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch:Hotfix Hacktoberfest Issues & PRs that count towards Hacktoberfest Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Mark issue has passed code review reviewed Status: Passed Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants