Fix #4646 - Hard coded messages in Surveys module

[jack7anderson7]

Fix #4646

Description

Update Survey module to contain labels instead of hard coded values

Motivation and Context

How To Test This

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

• My code follows the code style of this project found here.
• My change requires a change to the documentation.
• I have read the How to Contribute guidelines.

[likhobory]

@jack7anderson7

Please add translation for Show/Hide responses:

https://github.com/salesagility/SuiteCRM/blob/7.11.x/modules/Surveys/javascript/Survey.js#L9

and for Options / Add option

https://github.com/salesagility/SuiteCRM/blob/7.11.x/modules/Surveys/tpls/editsurveyquestions.tpl#L135
https://github.com/salesagility/SuiteCRM/blob/7.11.x/modules/Surveys/tpls/editsurveyquestions.tpl#L138

[likhobory]

@jack7anderson7

Thanks, also add please translation for those strings:

Question
https://github.com/salesagility/SuiteCRM/blob/7.11.x/modules/SurveyResponses/tpls/detailquestionresponses.tpl#L6

Response
https://github.com/salesagility/SuiteCRM/blob/7.11.x/modules/SurveyResponses/tpls/detailquestionresponses.tpl#L9

Question type
https://github.com/salesagility/SuiteCRM/blob/7.11.x/modules/Surveys/tpls/detailsurveyquestions.tpl#L24

Thanks for completing this survey.
https://github.com/salesagility/SuiteCRM/blob/7.11.x/modules/Surveys/Entry/Thanks.php#L26

Thanks for your interest but this survey is now closed.
https://github.com/salesagility/SuiteCRM/blob/7.11.x/modules/Surveys/Entry/Survey.php#L387

[clemente-raposo]

LGTM

[johnM2401]

LGTM, all labels changed in survey module are translatable when lang pack is used.

[SinergiaCRM]

@jack7anderson7, @clemente-raposo, @johnM2401, @likhobory and @Dillon-Brown

We have detected that this change is generating an error as the CRM treats the LBL_DRAFT value as a text string and not as a label:

https://github.com/salesagility/SuiteCRM/blob/v7.10-beta-2/modules/Surveys/vardefs.php#L51

It seems to work since when the LBL_DRATF value is not found in the list associated with the field, the first result of the list is returned, which in this case is Draft.

We think you should revert the change and leave the value 'Draft'. Also, we think the LBL_DRAFT tag can be removed from the language file, as it is not used elsewhere.