Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9817 - Typo #9817

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Fix #9817 - Typo #9817

merged 1 commit into from
Apr 14, 2023

Conversation

gunnicom
Copy link
Contributor

Description

Motivation and Context

How To Test This

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@jack7anderson7 jack7anderson7 mentioned this pull request Nov 14, 2022
Closed
6 tasks
@jack7anderson7 jack7anderson7 changed the base branch from master to hotfix November 21, 2022 10:55
@jack7anderson7 jack7anderson7 added Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Branch:Hotfix labels Nov 21, 2022
@jack7anderson7 jack7anderson7 mentioned this pull request Nov 21, 2022
Merged
6 tasks
@gunnicom gunnicom changed the title Typo Fix #9817 - Typo Nov 21, 2022
@jack7anderson7 jack7anderson7 added the Status: Requires Code Review Needs the core team to code review label Feb 27, 2023
@clemente-raposo
Copy link
Contributor

Hi @gunnicom, thank you for your PR

@clemente-raposo clemente-raposo added Status: Requires Testing Requires Manual Testing Status: Passed Code Review Mark issue has passed code review reviewed and removed Status: Requires Code Review Needs the core team to code review labels Mar 3, 2023
johnM2401
johnM2401 approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@johnM2401 johnM2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnM2401 johnM2401 added Status: Passed Testing and removed Status: Requires Testing Requires Manual Testing labels Apr 10, 2023
@jack7anderson7 jack7anderson7 merged commit 460d871 into salesagility:hotfix Apr 14, 2023
jack7anderson7 pushed a commit that referenced this pull request Apr 24, 2023
@gunnicom @jack7anderson7
Fix #9817 - Typo
76b23f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnM2401 johnM2401 johnM2401 approved these changes

@clemente-raposo clemente-raposo clemente-raposo approved these changes

Assignees
No one assigned
Labels
Branch:Hotfix Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Mark issue has passed code review reviewed Status: Passed Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gunnicom @clemente-raposo @johnM2401 @jack7anderson7