Fix #9914 - Update dashboard.scss for dashlet options overflow #9914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2xaronl
changed the title
|
Hello, @2xaronl Could you please update your commit message to follow the formatting Fix #num - message. The number added in this case would be the number of the PR (9914). You can see more information on raising bugs/ PR's here: Thanks in advance, |
2xaronl
changed the title
serhiisamko091184
added
Status: Requires Code Review
…rflow Prior to this change, overflow of the dashlet options popup div were set to hidden. Now they are set to auto to allow scrollbars when content overflows.
clemente-raposo
added
Status: Requires Testing
johnM2401
added
Status: Passed Testing
and removed
Status: Requires Testing
jack7anderson7
pushed a commit
that referenced
this pull request
Mar 2, 2023
Prior to this change, overflow of the dashlet options popup div were set to hidden. Now they are set to auto to allow scrollbars when content overflows.
JanSiero
added a commit
to JanSiero/SuiteCRM
that referenced
this pull request
Mar 30, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, overflow of the dashlet options popup div were set to hidden. Now they are set to auto to allow scrollbars when content overflows.
Description
In my SuiteCRM instance, the Save and Clear buttons were not accessible in the 'My Open Cases : Options' popup when configuring the dashlet.
Motivation and Context
Overflow of the div containing the options in the popup was set to hidden and the max-height was insufficient to display all of the options plus the buttons. Rather than change the max-height (which may need to be readjusted in the future), I figured that allowing the div to vertically scroll was a better solution.
How To Test This
Rebuild sass
Types of changes
Final checklist