optimization/http method registration simplification

Gruntfile.js

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) 2014​, salesforce.com, inc.
+ * Copyright (c) 2015​, salesforce.com, inc.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without modification, are permitted provided

lib/fuel-rest.js

@@ -1,5 +1,5 @@
 /**
-* Copyright (c) 2014​, salesforce.com, inc.
+* Copyright (c) 2015​, salesforce.com, inc.
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without modification, are permitted provided
@@ -23,17 +23,18 @@
 * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 * POSSIBILITY OF SUCH DAMAGE.
 */
+'use strict';
 
-var version  = require('../package.json').version;
-var helpers  = require('./helpers');
-var request  = require('request');
 var _        = require('lodash');
 var FuelAuth = require('fuel-auth');
+var helpers  = require('./helpers');
 var Promiser = (typeof Promise === 'undefined') ? require('bluebird') : Promise;
+var request  = require('request');
+var version  = require('../package.json').version;
 
-var FuelRest = function(options) {
-	'use strict';
+var methods  = ['get', 'post', 'put', 'patch', 'delete'];
 
+var FuelRest = function(options) {
 	var authOptions = options && options.auth || {};
 
 	// use fuel auth instance if applicable
@@ -60,8 +61,6 @@ var FuelRest = function(options) {
 };
 
 FuelRest.prototype.apiRequest = function(options, callback) {
-	'use strict';
-
 	var self = this;
 
 	// we need options
@@ -144,49 +143,14 @@ FuelRest.prototype.apiRequest = function(options, callback) {
 		});
 };
 
-FuelRest.prototype.get = function(options, callback) {
-	'use strict';
-
-	options.method = 'GET';
-	options.retry  = true;
-
-	return this.apiRequest(options, callback);
-};
-
-FuelRest.prototype.post = function(options, callback) {
-	'use strict';
-
-	options.method = 'POST';
-	options.retry  = true;
+// setup simple http methods
+methods.forEach(function(method) {
+	FuelRest.prototype[method] = function(options, callback) {
+		options.method = method.toUpperCase();
+		options.retry  = true;
 
-	return this.apiRequest(options, callback);
-};
-
-FuelRest.prototype.put = function(options, callback) {
-	'use strict';
-
-	options.method = 'PUT';
-	options.retry  = true;
-
-	return this.apiRequest(options, callback);
-};
-
-FuelRest.prototype.patch = function(options, callback) {
-	'use strict';
-
-	options.method = 'PATCH';
-	options.retry  = true;
-
-	return this.apiRequest(options, callback);
-};
-
-FuelRest.prototype.delete = function(options, callback) {
-	'use strict';
-
-	options.method = 'DELETE';
-	options.retry  = true;
-
-	return this.apiRequest(options, callback);
-};
+		return this.apiRequest(options, callback);
+	};
+});
 
 module.exports = FuelRest;

package.json

@@ -4,7 +4,7 @@
   "description": "Node library for performing REST API calls to Salesforce Marketing Cloud (formerly ExactTarget).",
   "main": "./lib/fuel-rest.js",
   "scripts": {
-    "test": "grunt && ./node_modules/mocha/bin/mocha --reporter=spec test/specs/*.js"
+    "test": "grunt && node ./node_modules/mocha/bin/mocha --reporter=spec test/specs/*.js"
   },
   "repository": {
     "type": "git",

test/config.js

@@ -1,5 +1,5 @@
 /**
-* Copyright (c) 2014​, salesforce.com, inc.
+* Copyright (c) 2015​, salesforce.com, inc.
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without modification, are permitted provided

test/mock-server.js

@@ -1,5 +1,5 @@
 /**
-* Copyright (c) 2014​, salesforce.com, inc.
+* Copyright (c) 2015​, salesforce.com, inc.
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without modification, are permitted provided

test/sample-responses.js

@@ -1,5 +1,5 @@
 /**
-* Copyright (c) 2014​, salesforce.com, inc.
+* Copyright (c) 2015​, salesforce.com, inc.
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without modification, are permitted provided

test/specs/fn-apiRequest.js

@@ -1,5 +1,5 @@
 /**
-* Copyright (c) 2014​, salesforce.com, inc.
+* Copyright (c) 2015​, salesforce.com, inc.
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without modification, are permitted provided

test/specs/fn-http-methods.js

@@ -1,5 +1,5 @@
 /**
-* Copyright (c) 2014​, salesforce.com, inc.
+* Copyright (c) 2015​, salesforce.com, inc.
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without modification, are permitted provided

test/specs/general-tests.js

@@ -1,5 +1,5 @@
 /**
-* Copyright (c) 2014​, salesforce.com, inc.
+* Copyright (c) 2015​, salesforce.com, inc.
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without modification, are permitted provided

test/specs/helpers.js

@@ -1,5 +1,5 @@
 /**
-* Copyright (c) 2014​, salesforce.com, inc.
+* Copyright (c) 2015​, salesforce.com, inc.
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without modification, are permitted provided