Use the right Android XML Tags #154
Conversation
|
Thanks for the contribution! Before we can merge this, we need @JolandaVerhoef to sign the Salesforce.com Contributor License Agreement. |
|
Thanks for the contribution. Both of the Android PR's look good to me. I just had one question. Should we also merge #144 so we are using the correct tags and placing the value inside the tag? @JolandaVerhoef @craveytrain @larsonjj |
|
@aputinski Yes, according to the Android documentation the values should be placed inside the tag. So it would be great if #144 could also be merged! |
|
@aputinski Can the current open PRs be merged? They have been stale for two weeks now, would love to have them in the project. |
|
Sorry about that. I just merged #144, so if you fix the conflicts, I'll go ahead and get these merged. Then we'll just need to write some release notes and do a major version bump. |
JolandaVerhoef
force-pushed
the
format-android
branch
3 times, most recently
from
d95917d to
f19dc75
Compare
JolandaVerhoef
force-pushed
the
format-android
branch
from
f19dc75 to
45aeebf
Compare
|
@aputinski I fixed the conflicts! :) |
|
Would you mind also updating the documentation in this PR? |
|
@aputinski Documentation is updated! |
|
Thanks! I'll try to draft a release later this week. |
As documented on this page Android developers can't use the
propertytag for XML.This PR adapts the XML output to use the right tags based on the value type.