Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update names of transformer tests and files to match class names #284

Merged
merged 9 commits into from
Apr 16, 2019
Merged

Update names of transformer tests and files to match class names #284

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f3f1fd2
match up names for OpLDA and test
crupley Apr 15, 2019
1bf74c0
rename OpLDATest everywhere
crupley Apr 15, 2019
9a5953a
rename StandardScalar test to match
crupley Apr 15, 2019
26058ee
rename TextMapPivotVectorizer test to match
crupley Apr 15, 2019
ddc8de1
rename Transmogrifier test to match
crupley Apr 15, 2019
7f17d93
Merge branch 'master' into master
crupley Apr 15, 2019
cd3087a
Merge branch 'master' of github.com:salesforce/TransmogrifAI
crupley Apr 15, 2019
be6a08e
Merge branch 'master' of github.com:crupley/TransmogrifAI
crupley Apr 15, 2019
41c513f
test for OpLDA not OpLDATest
crupley Apr 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ce/op/stages/impl/feature/OpLdaTest.scala → ...ce/op/stages/impl/feature/OpLDATest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ import org.scalatest.{Assertions, FlatSpec, Matchers}


@RunWith(classOf[JUnitRunner])
class OpLdaTest extends FlatSpec with TestSparkContext {
class OpLDATest extends FlatSpec with TestSparkContext {

val inputData = Seq(
(0.0, Vectors.sparse(11, Array(0, 1, 2, 4, 5, 6, 7, 10), Array(1.0, 2.0, 6.0, 2.0, 3.0, 1.0, 1.0, 3.0))),
Expand Down Expand Up @@ -78,7 +78,7 @@ class OpLdaTest extends FlatSpec with TestSparkContext {
.toSeq
.map(_.getAs[Vector](0))

Spec[OpLdaTest] should "convert document term vectors into topic vectors" in {
Spec[OpLDATest] should "convert document term vectors into topic vectors" in {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec[OpLDA]

val f2Vec = new OpLDA().setInput(f2).setK(k).setSeed(seed).setMaxIter(maxIter)
val testTransformedData = f2Vec.fit(inputDS).transform(inputDS)
val output = f2Vec.getOutput()
Expand Down
2 changes: 1 addition & 1 deletion ...s/impl/feature/OpStandardScalerTest.scala → .../feature/OpScalarStandardScalerTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ import org.scalatest.junit.JUnitRunner


@RunWith(classOf[JUnitRunner])
class OpStandardScalerTest extends FlatSpec with TestSparkContext {
class OpScalarStandardScalerTest extends FlatSpec with TestSparkContext {
import spark.implicits._

// TODO: use TestFeatureBuilder instead
Expand Down
4 changes: 2 additions & 2 deletions .../impl/feature/TextMapVectorizerTest.scala → .../feature/TextMapPivotVectorizerTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ import org.slf4j.LoggerFactory


@RunWith(classOf[JUnitRunner])
class TextMapVectorizerTest extends FlatSpec with TestSparkContext with AttributeAsserts {
class TextMapPivotVectorizerTest extends FlatSpec with TestSparkContext with AttributeAsserts {

val log = LoggerFactory.getLogger(classOf[TextMapVectorizerTest])
val log = LoggerFactory.getLogger(classOf[TextMapPivotVectorizerTest])

lazy val (dataSet, top, bot) = TestFeatureBuilder("top", "bot",
Seq(
Expand Down
2 changes: 1 addition & 1 deletion ...tages/impl/feature/TransmogrifyTest.scala → ...ges/impl/feature/TransmogrifierTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ import org.scalatest.FlatSpec
import org.scalatest.junit.JUnitRunner

@RunWith(classOf[JUnitRunner])
class TransmogrifyTest extends FlatSpec with PassengerSparkFixtureTest with AttributeAsserts {
class TransmogrifierTest extends FlatSpec with PassengerSparkFixtureTest with AttributeAsserts {

val inputFeatures = Array[OPFeature](heightNoWindow, weight, gender)

Expand Down