-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added base spec for testing Spark wrapping transformers #295
Conversation
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
==========================================
- Coverage 86.41% 86.23% -0.18%
==========================================
Files 319 320 +1
Lines 10452 10471 +19
Branches 346 562 +216
==========================================
- Hits 9032 9030 -2
- Misses 1420 1441 +21
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I am just curious if checking the underlying type of the wrapper is really necessary.
features/src/main/scala/com/salesforce/op/test/OpTransformerSpec.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aside from one typo, LGTM
…ec.scala Co-Authored-By: tovbinm <[email protected]>
@wsuchy maybe not as it should be checked by compiler. But I dont think there is anything wrong to check in a test as well. |
Thanks for the contribution! It looks like @tovbinm is an internal user so signing the CLA is not required. However, we need to confirm this. |
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Matthew Tovbin <m***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request. |
Related issues
Spark wrapping transformers were missing a test spec
Describe the proposed solution
SwTransformerSpec
for testing Spark wrapping transformersOpTransformerSpec
andSwTransformerSpec
into privateTransformerSpecCommon
OpIndexToStringTest
to use it