This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Feature/88 parser to support idea file #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeiShmidman
requested review from
kkazakevich,
PMitrafanau and
LeonovecSergey
aspect versions. ("bef" standands for BEF version and all others for
IntelliJ)
AlexeiShmidman
force-pushed
the
feature/88-parser-to-support-idea-file
branch
from
a678dba to
6aca7b1
Compare
PMitrafanau
suggested changes
Apr 12, 2021
...e.b2eclipse.jdt.ls/src/main/java/com/salesforce/b2eclipse/managers/BazelProjectImporter.java
Outdated
Show resolved
Hide resolved
...e.b2eclipse.jdt.ls/src/main/java/com/salesforce/b2eclipse/managers/BazelProjectImporter.java
Outdated
Show resolved
Hide resolved
...ipse.jdt.ls/src/main/java/com/salesforce/b2eclipse/util/IntellijAspectPackageInfoLoader.java
Outdated
Show resolved
Hide resolved
...ipse.jdt.ls/src/main/java/com/salesforce/b2eclipse/util/IntellijAspectPackageInfoLoader.java
Outdated
Show resolved
Hide resolved
...2eclipse.tests/src/main/java/com/salesforce/b2eclipse/managers/BazelProjectImporterTest.java
Outdated
Show resolved
Hide resolved
...2eclipse.tests/src/main/java/com/salesforce/b2eclipse/managers/BazelProjectImporterTest.java
Outdated
Show resolved
Hide resolved
...2eclipse.tests/src/main/java/com/salesforce/b2eclipse/managers/BazelProjectImporterTest.java
Outdated
Show resolved
Hide resolved
...2eclipse.tests/src/main/java/com/salesforce/b2eclipse/managers/BazelProjectImporterTest.java
Outdated
Show resolved
Hide resolved
...2eclipse.tests/src/main/java/com/salesforce/b2eclipse/managers/BazelProjectImporterTest.java
Outdated
Show resolved
Hide resolved
...2eclipse.tests/src/main/java/com/salesforce/b2eclipse/managers/BazelProjectImporterTest.java
Outdated
Show resolved
Hide resolved
2. use method reference (IntellijAspectPackageInfoLoader::isValid)
kkazakevich
approved these changes
Apr 12, 2021
PMitrafanau
approved these changes
Apr 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Additional Info