Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added info window popup to project view change event #69

Closed
wants to merge 1 commit into from

Conversation

lonhutt
Copy link
Contributor

@lonhutt lonhutt commented Dec 21, 2023

added info window popup to project view change event

Copy link

github-actions bot commented Dec 21, 2023

Test Results

 2 files  ±0   2 suites  ±0   5h 36m 50s ⏱️ - 11m 19s
 6 tests ±0   6 ✅ ±0  0 💤 ±0  0 ❌ ±0 
12 runs  ±0  12 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2dc2dee. ± Comparison against base commit e35ea48.

♻️ This comment has been updated with latest results.

src/extension.ts Outdated
@@ -135,6 +135,14 @@ function toggleBazelClasspathSyncStatus(doc: TextDocument){
}

function toggleBazelProjectSyncStatus(doc: TextDocument){
window.showInformationMessage('Project View Updated', 'Sync Project View', 'Sync Directories Only')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that if someone clicks on the Status bar item for "Sync bazel project view", this popup would still be visible. Should we look into programmatically closing this popup?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there's no good way to do this currently: microsoft/vscode#2732

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it should be a setStatusBarMessage instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well we already have a status bar item that toggles on/off when the .bazelproject file is edited/project sync is triggered

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might look into a better way to display project view sync status beyond a simple status bar item; but that feels out of scope for this PR

@lonhutt lonhutt force-pushed the lhutt/add_project_sync_info_window branch from 0f1c372 to 9576ab1 Compare January 2, 2024 19:28
@guw
Copy link
Contributor

guw commented Jan 2, 2024

What does IJ do when the user updates the .bazelproject file? In Eclipse I do nothing. I let the user make the decision when to sync.

@lonhutt lonhutt force-pushed the lhutt/add_project_sync_info_window branch 2 times, most recently from 9e973b3 to 401aaaf Compare January 4, 2024 19:03
@lonhutt lonhutt force-pushed the lhutt/add_project_sync_info_window branch from 401aaaf to 2dc2dee Compare January 11, 2024 22:55
@AdwaitChavan
Copy link

AdwaitChavan commented Jan 12, 2024

What does IJ do when the user updates the .bazelproject file? In Eclipse I do nothing. I let the user make the decision when to sync.

IJ does not give any UI feedback either on updating the .bazelproject file. However, I think this popup approach was chosen as some users gave feedback that the Sync Bazel Project status bar item in VSCode does not look clickable.

@AdwaitChavan
Copy link

@lonhutt Just wanted to check if this change would need any documentation updates?

@guw guw closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants