-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added info window popup to project view change event #69
Conversation
src/extension.ts
Outdated
@@ -135,6 +135,14 @@ function toggleBazelClasspathSyncStatus(doc: TextDocument){ | |||
} | |||
|
|||
function toggleBazelProjectSyncStatus(doc: TextDocument){ | |||
window.showInformationMessage('Project View Updated', 'Sync Project View', 'Sync Directories Only') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed that if someone clicks on the Status bar item for "Sync bazel project view", this popup would still be visible. Should we look into programmatically closing this popup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like there's no good way to do this currently: microsoft/vscode#2732
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it should be a setStatusBarMessage
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well we already have a status bar item that toggles on/off when the .bazelproject file is edited/project sync is triggered
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might look into a better way to display project view sync status beyond a simple status bar item; but that feels out of scope for this PR
0f1c372
to
9576ab1
Compare
What does IJ do when the user updates the |
9e973b3
to
401aaaf
Compare
401aaaf
to
2dc2dee
Compare
IJ does not give any UI feedback either on updating the |
@lonhutt Just wanted to check if this change would need any documentation updates? |
added info window popup to project view change event