Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only remove slot children in synthetic shadow #2843

Merged
merged 2 commits into from
May 25, 2022
Merged

fix: only remove slot children in synthetic shadow #2843

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cfee1c
fix: only remove slot children in synthetic shadow
nolanlawson May 19, 2022
42c37c5
fix: use case block
nolanlawson May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/@lwc/engine-core/src/framework/rendering.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,11 +284,15 @@ function unmount(vnode: VNode, parent: ParentNode, doRemove: boolean = false) {
removeNode(elm!, parent);
}

const removeChildren = sel === 'slot'; // slot content is removed to trigger slotchange event when removing slot
switch (type) {
case VNodeType.Element:
case VNodeType.Element: {
// Slot content is removed to trigger slotchange event when removing slot.
// Only required for synthetic shadow.
const removeChildren =
sel === 'slot' && vnode.owner.shadowMode === ShadowMode.Synthetic;
unmountVNodes(vnode.children, elm as ParentNode, removeChildren);
break;
}

case VNodeType.CustomElement: {
const { vm } = vnode;
Expand Down