Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release v.2.14.2 @W-7258582 #2874

Merged
merged 14 commits into from
Jun 13, 2022
Merged

chore: release v.2.14.2 @W-7258582 #2874

merged 14 commits into from
Jun 13, 2022

Conversation

jye-sf
Copy link
Contributor

@jye-sf jye-sf commented Jun 7, 2022

No description provided.

nolanlawson and others added 14 commits May 25, 2022 13:29
@nolanlawson
fix: only remove slot children in synthetic shadow (#2843)
aca0f46 
* fix: only remove slot children in synthetic shadow

* fix: use case block
@nolanlawson
fix: only add version mismatch test code in karma (#2852)
b2beef0
@nolanlawson
test(integration-karma): ensure constructable stylesheets are re-used (…
4607057 
…#2844)

* test(integration-karma): ensure constructable stylesheets are re-used

* test: add test for shared style
@nolanlawson
chore(nucleus): remove more downstreams (#2855)
a5de058
@nolanlawson
chore(nucleus): remove another downstream (#2857)
eaffabb
@mohanraj-r @ekashida
docs: fix typo in template compiler readme (#2848)
c14e351 
* docs: fix typo in template compiler readme

* docs: rewording usage of lwc dynamic directive

Co-authored-by: Eugene Kashida <[email protected]>

Co-authored-by: Eugene Kashida <[email protected]>
@nolanlawson
test(integration-karma): update ACT components (#2862)
6059192
@nolanlawson @ekashida
fix(engine-core): revert "optimize computation of transitive shadow m…
27eee98 
…ode" (#2859)

* fix(engine-core): correctly compute shadowMode

* fix: fix comment

* fix: update packages/integration-karma/test/mixed-shadow-mode/dual-component/index.spec.js

Co-authored-by: Eugene Kashida <[email protected]>

* fix: fix another one

* fix: improve tests

* fix: improve tests

* fix: improve test

* fix: revert

* Revert "refactor(engine): optimize computation of transitive shadow mode (#2803)"

This reverts commit 95ce4c3.

Co-authored-by: Eugene Kashida <[email protected]>
@ravijayaramappa
chore: release v2.14.1 (#2866)
ec3a14f
@caridy @ravijayaramappa
@pmdartus @nolanlawson
refactor(engine-core): encapsulate renderer as an object and allow it…
da49079 
… to be injectable in vnodes (#2763)

* refactor(engine-core): passing the renderer from an import statement in compiled templates

Co-authored-by: Ravi Jayaramappa <[email protected]>
Co-authored-by: Pierre-Marie Dartus <[email protected]>
Co-authored-by: Nolan Lawson <[email protected]>
@nolanlawson
test(integration-karma): more shadow transitivity tests (#2864)
8685e89
@jye-sf
chore: release v.2.14.2 @W-7258582 (#2871)
a016322
@jye-sf
Revert "chore: release v2.14.1 (#2866) @W-7258582 (#2867)"
78b4516 
This reverts commit 518ab2e.
@jye-sf
Merge branch 'master' into jye/release/v2.14.2
b7b4d67
@jye-sf
Copy link
Contributor Author

jye-sf commented Jun 7, 2022

I had to revert the 2.14.1 release commit from #2867 to avoid having to manually resolve most of the files. Merging all those changes as a single commit made the commit trees diverge so Github wasn't able to auto merge.

This should bring the trees back into alignment. Will verify later this week if/when we need another release.

@divmain do you have any concerns around doing this? Would we lose anything from your commit that I should add back in?

@jye-sf jye-sf requested a review from divmain June 7, 2022 17:05
@salesforce-nucleus
Copy link
Contributor

❌ One or More Pre-release Checks Failed

  • ✅ Check PR user has rights to execute the workflow
    PR owner is allowed to initiate release/deploy
  • ❌ Check PR is approved
    PR 2874 must be approved by at least one approver
  • ✅ Check PR is mergeable
    PR 2874 is mergeable
  • ✅ Check GUS reference is present
    GUS Work Item @W-7258582 parsed from PR title
  • ✅ Check no conflicting Github release
  • ✅ Check NPM packages have not been released yet
  • ⚪️ Check Maven artifacts have not been released yet (skipped)
    Skipping check since project doesn't deliver Maven artifacts
  • ⚪️ Check GAV mapping exists for jar repo (skipped)
    Skipping GAV mapping check because a core jar is not being released.

@salesforce-nucleus
Copy link
Contributor

✅ All Pre-release Checks Passed

  • ✅ Check PR user has rights to execute the workflow
    PR owner is allowed to initiate release/deploy
  • ✅ Check PR is approved
    PR 2874 is approved
  • ✅ Check PR is mergeable
    PR 2874 is mergeable
  • ✅ Check GUS reference is present
    GUS Work Item @W-7258582 parsed from PR title
  • ✅ Check no conflicting Github release
  • ✅ Check NPM packages have not been released yet
  • ⚪️ Check Maven artifacts have not been released yet (skipped)
    Skipping check since project doesn't deliver Maven artifacts
  • ⚪️ Check GAV mapping exists for jar repo (skipped)
    Skipping GAV mapping check because a core jar is not being released.

@salesforce-nucleus
Copy link
Contributor

Error occurred when performing PR merge: This branch must not contain merge commits.

@salesforce-nucleus
Copy link
Contributor

❌ An unexpected error occurred while attempting to start the release stage of workflow 71294. Please try to start the stage again, or reach out to #nucleus-talk for help.

@ravijayaramappa ravijayaramappa merged commit 3db003f into release Jun 13, 2022
@ravijayaramappa ravijayaramappa deleted the jye/release/v2.14.2 branch June 13, 2022 03:25
@salesforce-nucleus
Copy link
Contributor

✅ All Pre-release Checks Passed

  • ⚪️ Check PR user has rights to execute the workflow (skipped)
    Skipping PR owner check since PR has already been merged.
  • ✅ Check PR is approved
    PR 2874 is approved
  • ⚪️ Check PR is mergeable (skipped)
    PR 2874 has already been merged
  • ✅ Check GUS reference is present
    GUS Work Item @W-7258582 parsed from PR title
  • ✅ Check no conflicting Github release
  • ✅ Check NPM packages have not been released yet
  • ⚪️ Check Maven artifacts have not been released yet (skipped)
    Skipping check since project doesn't deliver Maven artifacts
  • ⚪️ Check GAV mapping exists for jar repo (skipped)
    Skipping GAV mapping check because a core jar is not being released.

@salesforce-nucleus
Copy link
Contributor

🚢 Release Starting

This pull request has been merged and the release of version 2.14.2 is starting.

You can monitor the progress of the release in Nucleus by visiting the following URL.
https://nucleus.uipengsys-public.buildndeliver-s.aws-esvc1-useast2.aws.sfdc.cl/workflows/71294

@salesforce-nucleus
Copy link
Contributor

❌ An unexpected error occurred while attempting to start the update-downstream-deps stage of workflow 71294. Please try to start the stage again, or reach out to #nucleus-talk for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravijayaramappa ravijayaramappa ravijayaramappa approved these changes

@divmain divmain Awaiting requested review from divmain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jye-sf @ravijayaramappa @nolanlawson @mohanraj-r @caridy