Skip to content

Commit

Permalink
prefer classes over function prototypes to define classes (#156)
Browse files Browse the repository at this point in the history
* prefer classes over function prototypes to define classes
* chore: bring back allowSpecialUseDomain feature

BREAKING CHANGE: the original implementation added the 'allowSpecialUseDomain' parameter to the findCookies method signature in the Store, which violated the callback-last convention, which would have precluded Promise support, so the parameter has been moved ahead of the callback function.
  • Loading branch information
jstewmon authored and awaterma committed Nov 25, 2019
1 parent 9cb6662 commit 08f8141
Show file tree
Hide file tree
Showing 7 changed files with 1,000 additions and 1,003 deletions.
1 change: 1 addition & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"ecmaVersion": 6
},
"rules": {
"no-debugger": "error",
"no-var": "error",
"prefer-arrow-callback": "error",
"prefer-const": "error",
Expand Down
Loading

0 comments on commit 08f8141

Please sign in to comment.