Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ip-regex instead of net.isIP. Fix #125 #136

Merged
merged 1 commit into from
Jan 7, 2019

Conversation

gzzhanghao
Copy link
Contributor

Replace net.isIP with ip-regex.

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @gzzhanghao to sign the Salesforce.com Contributor License Agreement.

@stash
Copy link
Collaborator

stash commented Jan 7, 2019

Looks good to me. Breaks compatibility with node 0.10 and 0.12 though.

@stash
Copy link
Collaborator

stash commented Jan 7, 2019

request now has "node": ">= 6" and jsdom has ">=8" so maybe we should roll forward support to at least node 6?

@stash stash changed the base branch from master to issue-125 January 7, 2019 22:19
@stash stash merged commit 8aaa5c4 into salesforce:issue-125 Jan 7, 2019
@Turbo87
Copy link

Turbo87 commented Jan 12, 2019

@stash this has broken Node 4 and 6 compat too. ip-regex@3 is Node 8+, but tough-cookie (according to package.json) supports Node 6+. ultimately this is causing Jest to no longer work on Node 6 when installed via yarn.

=> Found "[email protected]"
info Reasons this module exists
   - "jest#jest-cli#jest-environment-jsdom#jsdom#request-promise-native#tough-cookie" depends on it

wjhsf pushed a commit that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants