Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert " use eslint and prettier to apply consistent, modern formatting" #167

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

awaterma
Copy link
Member

Reverts #155

3 tests are failing after the merge.

@awaterma awaterma requested a review from ruoho August 21, 2019 23:57
Copy link
Contributor

@ruoho ruoho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@awaterma
Copy link
Member Author

Reverting. I will also reopen the pull request (if possible) and @jstewmon and I can work together on the failing tests (if he's open to that).

@awaterma awaterma merged commit c1a791e into master Aug 22, 2019
@jstewmon
Copy link
Contributor

I'm taking a look. I saw the failures locally earlier when I was checking the wall clock time of lint / test, but thought it must have been a local issue since the tests were previously passing. 😕

@jstewmon
Copy link
Contributor

The ietf_data/parser.json file has expiration dates that elapsed recently.

@awaterma
Copy link
Member Author

Thank you @jstewmon. I just ran the tests against the previous top-level and see the same failures; I'll take a look at the ietf_data/parser.json and update.

@jstewmon
Copy link
Contributor

Tests are fixed on my modernize branch

@awaterma
Copy link
Member Author

Can you prepare another p/r? I can compare locally; running out of time today, but should be able to get the fix in tomorrow.

@jstewmon
Copy link
Contributor

You got it: #168

wjhsf pushed a commit that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants