Issue 160 #173
Merged
Issue 160 #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was added because .local domains are commonly used for testing
purposes inside internal/local networks.
added allowSpecialUseDomain to parameters so that it can be passed to
permuteDomain, line 103
|
Thanks for the contribution! Before we can merge this, we need @miggs125 to sign the Salesforce.com Contributor License Agreement. |
|
LGTM - Thanks for the PR. |
colincasey
added a commit
to colincasey/tough-cookie
that referenced
this pull request
Nov 14, 2021
This PR adds test cases for the `allowSpecialUseDomain` option introduced in [PR salesforce#173](salesforce#173). The special use domain check was changed to be a refinement on the public suffix check since both setting and retrieving cookies can fail since not all special use domains are considered public suffixes. The following cases are tested: * when the cookie jar is configured with `allowSpecialUseDomain=true`, the code will skip the lookup of a public suffix when a special use domain is detected * when the cookie jar is configured with `allowSpecialUseDomain=false`, the code will raise an error describing proper usage when a special use domain is detected
awaterma
added a commit
that referenced
this pull request
Dec 20, 2021
This PR adds test cases for the `allowSpecialUseDomain` option introduced in [PR #173](#173). The special use domain check was changed to be a refinement on the public suffix check since both setting and retrieving cookies can fail since not all special use domains are considered public suffixes. The following cases are tested: * when the cookie jar is configured with `allowSpecialUseDomain=true`, the code will skip the lookup of a public suffix when a special use domain is detected * when the cookie jar is configured with `allowSpecialUseDomain=false`, the code will raise an error describing proper usage when a special use domain is detected Co-authored-by: Andrew Waterman <[email protected]>
wjhsf
pushed a commit
that referenced
this pull request
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #160
I have added an additional CookieStore option named allowSpecialUseDomain to allow for special-use domains such as '.local'. This is useful for testing purposes, '.local' is a commonly used suffix in testing environments.The const array in permuteDomain includes only .local because that is what I mentioned in the original issue. However, I could add the rest if needed.
Here are some more links regarding special-use domains
https://en.wikipedia.org/wiki/List_of_Internet_top-level_domains#Special-Use_Domains
https://tools.ietf.org/html/rfc6761
passed all tests. Ran tests with
npm run testUpdated the README to reflect changes made