Skip to content

Commit

Permalink
fix: unsetting with set
Browse files Browse the repository at this point in the history
  • Loading branch information
iowillhoit committed Sep 13, 2022
1 parent 353cf29 commit 574140d
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/commands/config/set.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ export class Set extends ConfigCommand<ConfigResponses> {
const config: Config = await loadConfig(flags.global);
const configs = await this.parseConfigKeysAndValues();
for (const name of Object.keys(configs)) {
const value = configs[name] ?? '';
// We need to allow `undefined` here so that we can support unsetting with set=''
// See the "use set to unset a config key" NUT
const value = configs[name];
try {
// core's builtin config validation requires synchronous functions but there's
// currently no way to validate an org synchronously. Therefore, we have to manually
Expand Down

0 comments on commit 574140d

Please sign in to comment.