Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace .at(0) with [0] #214

Merged
merged 3 commits into from
Mar 2, 2023
Merged

fix: replace .at(0) with [0] #214

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a616ae
fix: replace .at(0) with [0]
WillieRuemmele Mar 2, 2023
1ccba89
chore: rework delete
WillieRuemmele Mar 2, 2023
2b2d068
test: fix invalid target-org/hub-org NUT on node 16, different error …
WillieRuemmele Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/commands/config/get.nut.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ describe('config get NUTs', async () => {
it('gets singular config correctly', () => {
const result = execCmd<ConfigResponses>('config get org-api-version --json', {
ensureExitCode: 0,
}).jsonOutput?.result.at(0);
}).jsonOutput?.result[0];
expect(result?.name).to.equal('org-api-version');
expect(result?.location).to.equal('Global');
expect(result?.value).to.equal('51.0');
Expand Down
4 changes: 3 additions & 1 deletion test/commands/config/set.nut.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ function verifyValidationError(key: string, value: string | number, message: str
];
const result = execCmd<Array<{ error: unknown }>>(`config set ${key}=${value} --json`, { cli: 'sf' }).jsonOutput
?.result;
delete result?.at(0)?.error;

delete result?.[0].error;

expect(result).to.deep.equal(expected);
execCmd(`config unset ${key}`);
}
Expand Down
2 changes: 1 addition & 1 deletion test/commands/sfdx/config/get.nut.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ describe('config:get NUTs', async () => {

it('gets singular config correctly', () => {
const res = execCmd<ConfigResponses>('config:get apiVersion --json', { ensureExitCode: 0 }).jsonOutput;
const result = res?.result.at(0) ?? ({} as Msg);
const result = res?.result[0] ?? ({} as Msg);
// the path variable will change machine to machine, ensure it has the config file and then delete it
expect(result.path).to.include('config.json');
expect(result.key).to.include('apiVersion');
Expand Down
10 changes: 5 additions & 5 deletions test/commands/sfdx/config/set.nut.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ function verifyValidationError(key: string, value: string | number) {
const res = execCmd<SetConfigCommandResult>(`config:set ${key}=${value} --json`).jsonOutput;
const result = res?.result.failures as Msg[];
// validate error message / failures error message here and delete, it will vary based on the value.
expect(result.at(0)?.message).to.include('Invalid config value:');
delete result.at(0)?.message;
expect(result[0]?.message).to.include('Invalid config value:');
delete result[0]?.message;
expect(res).to.deep.equal(expected);
execCmd(`config:unset ${key}`);
}
Expand All @@ -43,15 +43,15 @@ function verifyValidationStartsWith(key: string, value: string | number, message
const res = execCmd<SetConfigCommandResult>(`config:set ${key}=${value} --json`).jsonOutput;
expect(res?.result).to.have.property('successes').with.length(0);
expect(res?.result).to.have.property('failures').with.length(1);
const result = res?.result.failures.at(0) as Msg;
const result = res?.result.failures[0] as Msg;
expect(result.message?.startsWith(message)).to.be.true;
execCmd(`config:unset ${key}`);
}

function verifyKeysAndValuesJson(key: string, value: string | boolean) {
const res = execCmd<SetConfigCommandResult>(`config:set ${key}=${value} --json`, { ensureExitCode: 0 }).jsonOutput;
expect(res?.result.successes.at(0)?.message).to.include(`Deprecated config name: ${key}. Please use`);
delete res?.result.successes.at(0)?.message;
expect(res?.result.successes[0]?.message).to.include(`Deprecated config name: ${key}. Please use`);
delete res?.result.successes[0]?.message;
expect(res).to.deep.equal({
status: 0,
result: {
Expand Down