Migrate plugin-config commands #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
reviewed
Aug 15, 2022
| "@salesforce/dev-config": "^3.1.0", | ||
| "@salesforce/dev-scripts": "^2", | ||
| "@salesforce/dev-scripts": "^2.0.4", |
There was a problem hiding this comment.
there's a newer dev-scripts that updates the general (non-plugin) linter rules. Using that now saves some extra work later.
It'll bump some other deps and clean up unused deps, too.
Comment on lines
+34
to
+38
| let value = ''; | ||
| const configs = await this.parseConfigKeysAndValues(); | ||
| for (const name of Object.keys(configs)) { | ||
| try { | ||
| value = configs[name]; |
There was a problem hiding this comment.
avoids let, probably safe outside try/catch
Suggested change
| let value = ''; | |
| const configs = await this.parseConfigKeysAndValues(); | |
| for (const name of Object.keys(configs)) { | |
| try { | |
| value = configs[name]; | |
| const configs = await this.parseConfigKeysAndValues(); | |
| for (const name of Object.keys(configs)) { | |
| const value = configs[name] ?? ''; | |
| try { |
|
some feedback in a PR: #5 |
mshanemc
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Started with
plugin-template-sfas a baseMigrated
plugin-configv2commandsWhat issues does this PR fix or reference?
@W-11572657@