Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

black_box benchmark inputs and outputs #689

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

ibraheemdev
Copy link
Contributor

@ibraheemdev ibraheemdev commented Feb 13, 2025

I was getting some confusing benchmark results and it looks like some things may be getting optimized out. I added some black_box and assert statements to be safer.

Copy link

netlify bot commented Feb 13, 2025

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 46ba537
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/67ae7e3d3aeef40008cca24f

Copy link

codspeed-hq bot commented Feb 13, 2025

CodSpeed Performance Report

Merging #689 will not alter performance

Comparing ibraheemdev:black-box (46ba537) with master (03197cb)

Summary

✅ 9 untouched benchmarks

@Veykril Veykril added this pull request to the merge queue Feb 14, 2025
Merged via the queue into salsa-rs:master with commit ea1b2bd Feb 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants